Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PmgetTokenQuotes_Return_Type_Fix #144

Merged
merged 2 commits into from
Oct 3, 2024
Merged

PmgetTokenQuotes_Return_Type_Fix #144

merged 2 commits into from
Oct 3, 2024

Conversation

vignesha22
Copy link
Contributor

Description

  • Changed Return type of ethUSDPrice on pm_getTokenQuotes as per standard

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@vignesha22 vignesha22 merged commit 1ad7625 into master Oct 3, 2024
4 checks passed
@vignesha22 vignesha22 deleted the pmgetTokenQuotes_Return_Type_Fix branch October 3, 2024 12:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

@arddluma arddluma Awaiting requested review from arddluma

@kanthgithub kanthgithub Awaiting requested review from kanthgithub

@lbw33 lbw33 Awaiting requested review from lbw33

@nikhilkumar1612 nikhilkumar1612 Awaiting requested review from nikhilkumar1612

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vignesha22 @ch4r10t33r