Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

PRO-1968-Backward_Compatibility #29

Merged
merged 2 commits into from
Nov 13, 2023
Merged

PRO-1968-Backward_Compatibility #29

merged 2 commits into from
Nov 13, 2023

Conversation

vignesha22
Copy link
Contributor

@vignesha22 vignesha22 commented Nov 13, 2023 •
edited
Loading

Description

  • Fetched from params if apiKey and ChainId is not passed as queryString
  • Updated Readme file to include all the endpoints available and its significance

Types of changes

What types of changes does your code introduce?

  • Bugfix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Backward Compatible
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no api changes)
  • Build related changes
  • Other (please describe):

Further comments (optional)

@linear Linear
Copy link

linear bot commented Nov 13, 2023

PRO-1968 Arka Paymaster API to be compatible with other SDKs

https://portal.thirdweb.com/wallet/smart-wallet#optional-properties

Most of the SDK's allows custom paymaster to be set using paymasterUrl

ch4r10t33r
ch4r10t33r requested changes Nov 13, 2023
View reviewed changes
backend/package.json Outdated Show resolved Hide resolved
@cloudflare-workers-and-pages Cloudflare Workers and Pages
Copy link

cloudflare-workers-and-pages bot commented Nov 13, 2023 •
edited
Loading

Deploying with  Cloudflare Pages  Cloudflare Pages

Latest commit: c6861c9
Status: ✅  Deploy successful!
Preview URL: https://60ae0d21.arka-3qg.pages.dev
Branch Preview URL: https://pro-1968-added-backward-comp.arka-3qg.pages.dev

View logs

ch4r10t33r
ch4r10t33r approved these changes Nov 13, 2023
View reviewed changes
Copy link
Member

@ch4r10t33r ch4r10t33r left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@vignesha22 vignesha22 merged commit 7bb4d16 into master Nov 13, 2023
@vignesha22 vignesha22 deleted the PRO-1968-Added_Backward_Compatibility branch November 13, 2023 20:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ch4r10t33r ch4r10t33r ch4r10t33r approved these changes

@0xSulpiride 0xSulpiride Awaiting requested review from 0xSulpiride

@cryptonoyaiba cryptonoyaiba Awaiting requested review from cryptonoyaiba

@kaushalrajbacancy kaushalrajbacancy Awaiting requested review from kaushalrajbacancy

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@vignesha22 @ch4r10t33r