Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature/wallet connect 2.0 #23

Merged
merged 4 commits into from
Aug 31, 2023
Merged

Feature/wallet connect 2.0 #23

merged 4 commits into from
Aug 31, 2023

Conversation

poocart
Copy link
Contributor

@poocart poocart commented Aug 24, 2023

Description

Motivation and Context

  • Per description.

How Has This Been Tested?

  • Locally with React dapp and wagmi connector.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

vignesha22
vignesha22 approved these changes Aug 28, 2023
View reviewed changes
Copy link
Contributor

@vignesha22 vignesha22 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

0xSulpiride
0xSulpiride approved these changes Aug 31, 2023
View reviewed changes
Copy link
Member

@0xSulpiride 0xSulpiride left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poocart poocart merged commit dece48a into master Aug 31, 2023
2 checks passed
@poocart poocart deleted the feature/wallet-connect-2.0 branch August 31, 2023 09:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vignesha22 vignesha22 vignesha22 approved these changes

@kaushalrajbacancy kaushalrajbacancy kaushalrajbacancy approved these changes

@0xSulpiride 0xSulpiride 0xSulpiride approved these changes

@IAmKio IAmKio Awaiting requested review from IAmKio

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@poocart @0xSulpiride @kaushalrajbacancy @vignesha22