Skip to content

Commit

Permalink
fix: allow vc properties in participants_matrix.cl (#715)
Browse files Browse the repository at this point in the history
allow setting vc_* properties in participants_matrix.cl:

```
participants_matrix:
  el:
    - el_type: nethermind
      el_image: nethermindeth/nethermind:pectra
    - el_type: geth
      el_image: ethpandaops/geth:lightclient-prague-devnet-1
  cl:
    - cl_type: teku
      cl_image: ethpandaops/teku:master
    - cl_type: nimbus
      cl_image: ethpandaops/nimbus-eth2:unstable
    - cl_type: lodestar
      cl_image: ethpandaops/lodestar:electra-fork
      vc_max_mem: 1024
    - cl_type: grandine
      cl_image: ethpandaops/grandine:electra
```

in the example above, lodestar vc needs more than 500M memory for key
import, so I'd like to override the vc_max_mem accordingly.
This is theoretically allowed by the logic, but the new sanity check
prevents it.
  • Loading branch information
pk910 authored Jul 12, 2024
1 parent b824cac commit c8b9b19
Showing 1 changed file with 12 additions and 0 deletions.
12 changes: 12 additions & 0 deletions src/package_io/sanity_check.star
Original file line number Diff line number Diff line change
Expand Up @@ -82,6 +82,18 @@ PARTICIPANT_MATRIX_PARAMS = {
"cl_min_mem",
"cl_max_mem",
"use_separate_vc",
"vc_type",
"vc_image",
"vc_count",
"vc_log_level",
"vc_extra_env_vars",
"vc_extra_labels",
"vc_extra_params",
"vc_tolerations",
"vc_min_cpu",
"vc_max_cpu",
"vc_min_mem",
"vc_max_mem",
],
"vc": [
"vc_type",
Expand Down

0 comments on commit c8b9b19

Please sign in to comment.