feat: Add static ports #677
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
TobiWo
force-pushed
the
feature/add-static-ports
branch
6 times, most recently
from
8abbe6c
to
9c992f0
Compare
TobiWo
force-pushed
the
feature/add-static-ports
branch
9 times, most recently
from
59669f6
to
deac0f0
Compare
TobiWo
force-pushed
the
feature/add-static-ports
branch
2 times, most recently
from
e7090f9
to
84e909a
Compare
TobiWo
force-pushed
the
feature/add-static-ports
branch
3 times, most recently
from
1e746ee
to
57c07ae
Compare
barnabasbusa
reviewed
Jul 2, 2024
auto-merge was automatically disabled
July 3, 2024 14:21
Head branch was pushed to by a user without write access
* Add client settings * Add additional service settings * Delete global public port start
* Add participant id to launch and get_config method * Delete port id constants * Add port ids from constants * Delete kurtosis port spec getter * Add general kurtosis port spec getter from shared_utils
* Add port_publisher and vc_index to launch method * Add public ports to service config
* Reference metric port id from constants * Delete obsolete code
* Add port publisher config and service index as launcher arguments * Add public ports for services
* Delete unnecessary initial port number assignments * Add websocket port ID constant to port spec function
TobiWo
force-pushed
the
feature/add-static-ports
branch
from
9ef3fd4
to
b87acc6
Compare
barnabasbusa
approved these changes
Jul 3, 2024
|
LGTM |
barnabasbusa
pushed a commit
that referenced
this pull request
Jul 3, 2024
🤖 I have created a release *beep* *boop* --- ## [4.1.0](4.0.0...4.1.0) (2024-07-03) ### Features * add back k8s tests ([#699](#699)) ([d621cf0](d621cf0)) * add checkpoint_enabled and checkpoint_url flags ([#689](#689)) ([b8cd2b4](b8cd2b4)) * add eof support ([#682](#682)) ([cb203ff](cb203ff)) * add mev relays to dora config ([#679](#679)) ([293001a](293001a)) * Add static ports ([#677](#677)) ([4f054d0](4f054d0)) * add ws_url to el_context ([#696](#696)) ([26fea61](26fea61)) * introduce devnet_repo override ([#686](#686)) ([9952361](9952361)) * use CDN URL for data snapshots used for shadow forks ([#676](#676)) ([91dc68c](91dc68c)) ### Bug Fixes * besu bonsai log disable ([#673](#673)) ([955f19f](955f19f)) * blockscout bad return ([#685](#685)) ([e80870b](e80870b)) * bump peerdas images ([#678](#678)) ([1acc201](1acc201)) * DNS-1035 label ([#697](#697)) ([440fb31](440fb31)) * ephemery genesis loader ([#700](#700)) ([0235063](0235063)) * ignore bootnodes if in shadowfork ([#660](#660)) ([cda5dda](cda5dda)) * minimal eof ([#687](#687)) ([26a7618](26a7618)) * release please manifest ([#675](#675)) ([75ed7e1](75ed7e1)) * remove docker login ([#701](#701)) ([ede5962](ede5962)) * return empty services ([#688](#688)) ([6571a70](6571a70)) * return the correct network_id ([#705](#705)) ([7c592f6](7c592f6)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
This PR adds the possibility to define static ports for most of the components included in the ethereum-package for kurtosis.
Furthermore, some parts of the code, which are relevant for this PR, will be refactored.
Tasks