Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Minor updates #153

Open
wants to merge 5 commits into
base: testing
Choose a base branch
from
Open

Minor updates #153

wants to merge 5 commits into from

Conversation

NIC619
Copy link
Collaborator

@NIC619 NIC619 commented Mar 22, 2019

How was it fixed?

  • docker image name change
    • Rename sharding-p2p to sharding-p2p-poc
    • Change sharding-p2p-poc:dev to sharding-p2p-poc:testing
  • Fix show_pid and add spinup_node_with_bootstrapping
  • check return error of StartBootstrapping

Cute Animal Picture

put a cute animal picture link inside the parentheses

@NIC619 NIC619 requested a review from mhchia March 22, 2019 09:44
@NIC619
Copy link
Collaborator Author

NIC619 commented Mar 22, 2019

Not an important update. Leave it for now. Will come back to fix the CI errors.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@mhchia mhchia Awaiting requested review from mhchia

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@NIC619