-
Notifications
You must be signed in to change notification settings - Fork 19
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tracing(Opentracing + Appdash) #33
Conversation
Reference to #27 |
e315d8a
to
b05997f
Compare
TODOs
|
Specifically written for "opentracing", because it is used in some libp2p project and so every "import github.com/opentracing/opentracing-go" is rewritten in our project. However, we use `appdash` which is not used in libp2p projects, and is not rewritten when `gx-go rw`. This introduce conflict of types. So a temporary solution is to unwrite "opentracin-go" after `gx-go rw`
After every calls to `gx-go rw`
Add commands in Makefile: gx-partial-rw, gx-rw, gx-uw
I merged this branch with master, and modified |
Use local defined `unwrite_pkgs` instead of the global one, in the test
Ah...I just removed fstring. Hope we can get rid of the error. Thanks a lot @ChihChengLiang |
Seems like we forgot to fetch the dependency packages recursively while the command As for the previous |
So we need to pass |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
How was it fixed?
Add some basic tracing setup(Opentracing + Appdash) to keep track of the RPC calls between different nodes in the network:
AddPeer
span orSubscribeShard
span would be theChildOf
anRPC Server
span.RPC Server
span and multiple RPC call spans(e.g.,AddPeer
).SetTag
.Stop
call to turn down the RPC server so the main span(span with nameRPC Server
) can terminate normally.WIP: Look into libp2p codebase to see how they set up and utilize tracing
WIP: survey for different/better visualization tools
Cute Animal Picture