Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Workaround dial error in go test #51

Merged
merged 2 commits into from
Aug 22, 2018
Merged

Workaround dial error in go test #51

merged 2 commits into from
Aug 22, 2018

Conversation

mhchia
Copy link
Collaborator

@mhchia mhchia commented Aug 21, 2018 •
edited
Loading

What was wrong?

How was it fixed?

This is a workaround. Set unique listeningPort to every testing node, preventing port reuse across each test.

Cute Animal Picture

put a cute animal picture link inside the parentheses

ChihChengLiang
ChihChengLiang approved these changes Aug 22, 2018
View reviewed changes
Copy link
Collaborator

@ChihChengLiang ChihChengLiang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Locally tested, it works. Code looks good to me

@mhchia
Copy link
Collaborator Author

mhchia commented Aug 22, 2018

Thank you for the review:)

@mhchia mhchia merged commit ba8caa7 into ethresearch:master Aug 22, 2018
@mhchia mhchia deleted the fix/dial-error branch August 22, 2018 15:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ChihChengLiang ChihChengLiang ChihChengLiang approved these changes

@NIC619 NIC619 Awaiting requested review from NIC619

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@mhchia @ChihChengLiang