Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Filter errors for Collections with a double underscore (__) in the name #3687

Closed
SteveDMurphy opened this issue Jun 27, 2023 · 1 comment · Fixed by #3688
Closed

Filter errors for Collections with a double underscore (__) in the name #3687

SteveDMurphy opened this issue Jun 27, 2023 · 1 comment · Fixed by #3688
Assignees
Labels
bug Something isn't working

Comments

@SteveDMurphy
Copy link
Contributor

Bug Description

When processing a DSR, if a Collection has a double underscore in the name (__) it appears to cause an error when filtering on data categories.

Steps to Reproduce

  1. Create a Collection with a double underscore in the name (or multiple)
  2. Seed the data with data that would be processed via a DSR (i.e. email)
  3. Execute a DSR
  4. In the logs, see just a partial name for the Collection with an error
  5. Verify all connections seem to pass

Expected behavior

All of the connections pass, and the Collection name is preserved

Screenshots

n/a

Environment

  • Version: 2.14.3
  • OS: Darwin
  • Python Version: 3.10
  • Docker Version:

Additional context

n/a

@SteveDMurphy SteveDMurphy added the bug Something isn't working label Jun 27, 2023
@SteveDMurphy SteveDMurphy self-assigned this Jun 27, 2023
@SteveDMurphy
Copy link
Contributor Author

Confirmed this is happening -> https://github.com/ethyca/fides/blob/main/src/fides/api/task/task_resources.py#L150

Will have a PR up shortly, this should also handle fides_keys with a __ as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

1 participant