-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Handle Keys and Collections with a double underscore #3688
Handle Keys and Collections with a double underscore #3688
Conversation
282c5be
to
23baca6
Compare
Passing run #3002 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3688 +/- ##
=======================================
Coverage 87.05% 87.06%
=======================================
Files 310 310
Lines 18990 18997 +7
Branches 2446 2446
=======================================
+ Hits 16532 16539 +7
Misses 2029 2029
Partials 429 429
☔ View full report in Codecov by Sentry. |
23baca6
to
91b467c
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice fix - generally looks good to me, just had a small suggestion for what i think is a slightly simpler implementation! i'm also not 100% sure on your open question, so it may be good to get @pattisdr or @seanpreston's input on that one.
Co-authored-by: Adam Sachs <adam@ethyca.com>
…-key-error-double-underscore
Due to differences in the expected strings for an access or an erasure, it was determined that we may need to remove 2 or 3 items from the leading edge of the dataset. To avoid having the same function twice a parameter is now passed based on the string argument passed. The parameter name was also updated to be more descriptive
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
i like where you landed on this @SteveDMurphy! the number_of_leading_strings_to_exclude
arg makes sense, and the docstring of that function helps to make clear the functionality that otherwise may be a bit confounding for someone coming back to this code. nice work! 👍
Closes #3687
Description Of Changes
Found by a user with naming conventions that use a double underscore, which we weren't handling previously
Code Changes
Steps to Confirm
my__table__with__underscores
add some data, and run a DSR against it, running the failing test againstmain
will also show the result where onlyunderscores
would be returnedPre-Merge Checklist
CHANGELOG.md