Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 2.15.1 #3720

Closed
wants to merge 8 commits into from
Closed

Release 2.15.1 #3720

wants to merge 8 commits into from

Conversation

SteveDMurphy
Copy link
Contributor

@SteveDMurphy SteveDMurphy commented Jul 1, 2023

Closes #n/a

Code Changes

Release Checklist

The release checklist is a manual set of checks done before each release to ensure functionality of the most critical components of the application. Some of these steps are redundant with automated tests, while others are only tested here as part of this check.

This checklist should be copy/pasted into the final pre-release PR, and checked off as you complete each step.

Additionally, there is a robust Release Process page available in Confluence (internal only).

Pre-Release Steps

General

From the release branch, confirm the following:

  • Quickstart works: nox -s quickstart (verify you can complete the interactive prompts from the command-line) (skipped, fixed by postgres_setup.py fails due to circular import error #3691 )
  • Test environment works: nox -s "fides_env(test)" (verify the admin UI on localhost:8080, privacy center on localhost:3001, CLI and webserver)
  • Have Roger run a QATouch automation run

Next, run the following checks via the test environment:

API

CLI

Run these from within the test environment shell:

  • git reset --hard - Note: This is required for the pull command to work
  • fides user login
  • fides push src/fides/data/sample_project/sample_resources/
  • fides pull src/fides/data/sample_project/sample_resources/
  • fides evaluate src/fides/data/sample_project/sample_resources/
  • fides generate dataset db --credentials-id app_postgres test.yml - Note: Because the filesystem isn't mounted, the new file will only show up within the container
  • fides scan dataset db --credentials-id app_postgres

Privacy Center

  • Every navigation button works
  • DSR submission succeeds
  • Consent request submission succeeds

Admin UI

  • Every navigation button works
  • DSR approval succeeds
  • DSR execution succeeds

Documentation

  • Verify that the CHANGELOG is formatted correctly and clean up verbiage where needed
  • Verify that the CHANGELOG is representative of the actual changes

⚠️ Note that any updates that need to be made to the CHANGELOG should not be commited directly to the release branch.
Instead, they should be committed on a branch off of main and then PR'd and merged into main, before being cherry-picked
over to the release branch. This ensures that the CHANGELOG stays consistent between the release branch and main.

Publishing the release

When publishing the release, be sure to include the following sections in the release description:

  • ## Release Pull Request section that includes a link back to the release PR (i.e., this one!) for tracking purposes
  • ## QA Touch Test Run section that includes a link to the QATouch test run (QA team should provide this)

Post-Release Steps

@SteveDMurphy SteveDMurphy changed the base branch from main to release-2.15.0 July 1, 2023 21:42
@cypress
Copy link

cypress bot commented Jul 1, 2023

Passing run #3048 ↗︎

0 4 0 0 Flakiness 0

Details:

Merge df580b1 into 1c83e0b...
Project: fides Commit: aec41bb704 ℹ️
Status: Passed Duration: 01:05 💡
Started: Jul 5, 2023 6:13 PM Ended: Jul 5, 2023 6:14 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@codecov
Copy link

codecov bot commented Jul 1, 2023

Codecov Report

❗ No coverage uploaded for pull request base (release-2.15.0@1c83e0b). Click here to learn what that means.
Patch has no changes to coverable lines.

❗ Current head 367a394 differs from pull request most recent head 5a36682. Consider uploading reports for the commit 5a36682 to get more accurate results

Additional details and impacted files
@@                Coverage Diff                @@
##             release-2.15.0    #3720   +/-   ##
=================================================
  Coverage                  ?   87.10%           
=================================================
  Files                     ?      310           
  Lines                     ?    19040           
  Branches                  ?     2437           
=================================================
  Hits                      ?    16584           
  Misses                    ?     2028           
  Partials                  ?      428           

☔ View full report in Codecov by Sentry.
📢 Do you have feedback about the report comment? Let us know in this issue.

* fix for vuln

* Apply suggestions from code review

Use correct spelling of malicious.

Co-authored-by: Adam Sachs <adam@ethyca.com>

* Update src/fides/api/main.py

Verbiage

Co-authored-by: Thomas <thomas.lapiana+github@pm.me>

---------

Co-authored-by: Adam Sachs <adam@ethyca.com>
Co-authored-by: Thomas <thomas.lapiana+github@pm.me>
Co-authored-by: Dave Quinlan <83430497+daveqnet@users.noreply.github.com>
@SteveDMurphy SteveDMurphy self-assigned this Jul 5, 2023
@SteveDMurphy
Copy link
Contributor Author

Closing this as complete, with changelog updates merged in #3735 🎉

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants