Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Backend] Add Cookies and Surface with Privacy Notices #3572

Merged
merged 28 commits into from
Jun 21, 2023
Merged
Changes from 1 commit
Commits
Show all changes
28 commits
Select commit Hold shift + click to select a range
22cd8aa
Initial commit - add a Cookies table with FK's to PrivacyDeclaration …
pattisdr Jun 14, 2023
bb4282d
Add optional path and domain to Cookies and allow upsert_cookies to u…
pattisdr Jun 15, 2023
29e2a2d
Surface relevant cookies on privacy notices by data use.
pattisdr Jun 15, 2023
f4a6936
Update fideslang version which removes cookies from System request, a…
pattisdr Jun 15, 2023
f5cca57
Remove the index from path and domain.
pattisdr Jun 15, 2023
1e8247c
Merge branch 'main' into fides_3478_system_cookies
pattisdr Jun 15, 2023
c510d1d
Merge main:
pattisdr Jun 16, 2023
561290e
Try to make tests more predictable.
pattisdr Jun 16, 2023
df5a462
Update changelog.
pattisdr Jun 16, 2023
a5b9125
Merge branch 'main' into fides_3478_system_cookies
pattisdr Jun 19, 2023
04ce44a
Add missing fixture.
pattisdr Jun 19, 2023
399ec19
Merge main, conflicts:
pattisdr Jun 20, 2023
9911bf2
Bump fides lang commit to see if organization relationship key findin…
pattisdr Jun 20, 2023
ba64204
Make history tests more reliable - there's no guarantee that these ar…
pattisdr Jun 20, 2023
47010a9
Bump fideslang commit
pattisdr Jun 20, 2023
3ee9f3a
fix: bump fideslang version for testing
ThomasLaPiana Jun 21, 2023
e134836
Merge branch 'main' into fides_3478_system_cookies
ThomasLaPiana Jun 21, 2023
805393e
fix: pin pydantic to a new version supported by fideslang
ThomasLaPiana Jun 21, 2023
02ac533
Merge main, conflicts:
pattisdr Jun 21, 2023
f597094
Try sorting declarations for repeatability in tests.
pattisdr Jun 21, 2023
c8493db
Data use cookie field (#3571)
allisonking Jun 21, 2023
2720914
`fides-js` and privacy center cookie enforcement (#3569)
allisonking Jun 21, 2023
a879831
More attempts to improve reliability of cookie tests
pattisdr Jun 21, 2023
16d9355
Fix new mypy errors.
pattisdr Jun 21, 2023
9e0bb35
Bump fideslang to 1.4.2.
pattisdr Jun 21, 2023
d9988ef
Merge branch 'main' into fides_3478_system_cookies
pattisdr Jun 21, 2023
478a951
Merge branch 'main' into fides_3478_system_cookies
pattisdr Jun 21, 2023
d283aab
Classmethod placement was preventing validator from running.
pattisdr Jun 21, 2023
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Try sorting declarations for repeatability in tests.
  • Loading branch information
pattisdr committed Jun 21, 2023

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
commit f59709407e4bd9f1a27d66599f398573f24e4b35
14 changes: 7 additions & 7 deletions tests/ctl/core/test_system.py
Original file line number Diff line number Diff line change
@@ -395,7 +395,7 @@ async def test_new_cookies(self, test_cookie_system, async_session_temp):
system already has a cookie."""

new_cookies = [{"name": "apple"}]
privacy_declaration = test_cookie_system.privacy_declarations[0]
privacy_declaration = sorted(test_cookie_system.privacy_declarations, key=lambda x: x.name)[0]

await upsert_cookies(
async_session_temp,
@@ -423,8 +423,8 @@ async def test_new_cookies(self, test_cookie_system, async_session_temp):
async def test_no_change_to_cookies(self, test_cookie_system, async_session_temp):
"""Test specified cookies already exist on given privacy declaration, so no change required"""
new_cookies = [{"name": "strawberry"}]
privacy_declaration = test_cookie_system.privacy_declarations[1]
existing_cookie = test_cookie_system.privacy_declarations[1].cookies[0]
privacy_declaration = sorted(test_cookie_system.privacy_declarations, key=lambda x: x.name)[1]
existing_cookie = privacy_declaration.cookies[0]
assert existing_cookie.name == "strawberry"

await upsert_cookies(
@@ -454,8 +454,8 @@ async def test_update_cookies(self, test_cookie_system, async_session_temp):
"""Test specified cookies already exist on given privacy declaration, so no change required"""

new_cookies = [{"name": "strawberry", "path": "/"}]
privacy_declaration = test_cookie_system.privacy_declarations[1]
existing_cookie = test_cookie_system.privacy_declarations[1].cookies[0]
privacy_declaration = sorted(test_cookie_system.privacy_declarations, key=lambda x: x.name)[1]
existing_cookie = privacy_declaration.cookies[0]
assert existing_cookie.name == "strawberry"

await upsert_cookies(
@@ -485,8 +485,8 @@ async def test_remove_cookies(self, test_cookie_system, async_session_temp):
cookie and we remove the existing one"""

new_cookies = [{"name": "apple"}]
privacy_declaration = test_cookie_system.privacy_declarations[1]
existing_cookie = test_cookie_system.privacy_declarations[1].cookies[0]
privacy_declaration = sorted(test_cookie_system.privacy_declarations, key=lambda x: x.name)[1]
existing_cookie = privacy_declaration.cookies[0]
assert existing_cookie.name == "strawberry"

await upsert_cookies(