-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Deprecate connection config fields in UI #3684
Conversation
Passing run #2985 ↗︎
Details:
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. |
Codecov ReportPatch coverage:
Additional details and impacted files@@ Coverage Diff @@
## main #3684 +/- ##
===========================================
+ Coverage 65.27% 87.10% +21.83%
===========================================
Files 310 310
Lines 18993 19028 +35
Branches 2447 2436 -11
===========================================
+ Hits 12398 16575 +4177
+ Misses 6158 2026 -4132
+ Partials 437 427 -10
☔ View full report in Codecov by Sentry. |
This makes the migration not error out if a developer gets a weird inbetween state like I did
src/fides/api/alembic/migrations/versions/7315b9d7fda6_make_connectionconfig_name_optional.py
Outdated
Show resolved
Hide resolved
src/fides/api/alembic/migrations/versions/7315b9d7fda6_make_connectionconfig_name_optional.py
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks good, thanks for taking the time to go over the key/fides_key part
Closes fidesplus#947
Description Of Changes
This PR makes the
ConnectionConfig.name
field optional and removes both theConnectionConfig.name
andConnectionConfig.description
fields from the integration tab form.Code Changes
ConnectionConfig.name
optionalConnectionConfig.key
toConnectionConfig.name
for saas connectors if it's left empty. This is because the name isn't guaranteed to be there anymore. Now it defaults to the instance key.Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md