Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Removing required flag for the dataset field #3690

Merged
merged 1 commit into from
Jun 28, 2023
Merged

Removing required flag for the dataset field #3690

merged 1 commit into from
Jun 28, 2023

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jun 27, 2023

Closes #3657

Description Of Changes

Removing the "required" asterisk from the database field in the integration configuration form.

Code Changes

  • Removed isRequired from DatasetConfigField

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

@galvana galvana linked an issue Jun 27, 2023 that may be closed by this pull request
Release bug: dataset field should not be required #3657
Closed
@galvana galvana requested a review from TheAndrewJackson June 27, 2023 17:10
@cypress
Copy link

cypress bot commented Jun 27, 2023

Passing run #2928 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge b056b7c into 243f6e2...
Project: fides Commit: 941a73bd99 ℹ️
Status: Passed Duration: 01:14 💡
Started: Jun 27, 2023 5:31 PM Ended: Jun 27, 2023 5:33 PM

This comment has been generated by cypress-bot as a result of this project's GitHub integration settings.

@galvana galvana merged commit c7effb1 into main Jun 28, 2023
@galvana galvana deleted the 3657-dataset-field-should-not-be-required branch June 28, 2023 21:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@TheAndrewJackson TheAndrewJackson TheAndrewJackson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Release bug: dataset field should not be required
2 participants
@galvana @TheAndrewJackson