Segment Integration: user_id over email #5004
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5004 +/- ##
=======================================
Coverage 86.54% 86.54%
=======================================
Files 357 357
Lines 22331 22331
Branches 2955 2955
=======================================
Hits 19327 19327
Misses 2480 2480
Partials 524 524 ☔ View full report in Codecov by Sentry. |
| fidesops_meta: | ||
| fides_meta: | ||
| data_type: string | ||
| - name: first_name |
There was a problem hiding this comment.
additional fields found in testing (these may be configurable by client?)
| identity: email | ||
| references: | ||
| - dataset: <instance_fides_key> | ||
| field: traits.user_id |
There was a problem hiding this comment.
I chose to use the traits, but it could also be that we use external_ids however it will end up generating extra requests so decided against it for the time being
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Closes FIDES-746
Description Of Changes
It's been determined that the email cannot be used as the identity unless it is also the user_id. For this we need to infer the user_id from either traits or external_ids
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works