Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copy for MySQL/CloudSQL integration to be specific to Cloud SQL #5100

Merged
merged 6 commits into from
Jul 23, 2024
Merged

Update copy for MySQL/CloudSQL integration to be specific to Cloud SQL #5100

merged 6 commits into from
Jul 23, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

Closes #PROD-2317

Description Of Changes

Update copy for MySQL/CloudSQL integration to be specific to Cloud SQL

Code Changes

  • Updated copy on googleCloudSQLPostgresInfo.tsx
  • Updated copy on googleCloudSQLMySQLInfo.tsx

Steps to Confirm

  • Open the integrations menu and add a connection either of the Google Cloud connections.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@vercel Vercel
Copy link

vercel bot commented Jul 18, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Jul 23, 2024 6:23pm

@cypress Cypress
Copy link

cypress bot commented Jul 18, 2024 •
edited
Loading

Passing run #9107 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge fa2540f into 3aaa186...
Project: fides Commit: db4f953d34 ℹ️
Status: Passed Duration: 00:44 💡
Started: Jul 23, 2024 6:35 PM Ended: Jul 23, 2024 6:36 PM

Review all test suite changes for PR #5100 ↗︎

Kelsey-Ethyca
Kelsey-Ethyca requested changes Jul 23, 2024
View reviewed changes
Copy link
Contributor

@Kelsey-Ethyca Kelsey-Ethyca left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The copy update sounds good! Please run turbo run format in the clients folder and ensure all CI tests are passing.

@andres-torres-marroquin andres-torres-marroquin merged commit 805aa66 into main Jul 23, 2024
13 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the PROD-2312 branch July 23, 2024 18:46
@cypress Cypress
Copy link

cypress bot commented Jul 23, 2024

Passing run #9108 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Update copy for MySQL/CloudSQL integration to be specific to Cloud SQL (#5100)
Project: fides Commit: 805aa66782
Status: Passed Duration: 00:35 💡
Started: Jul 23, 2024 6:58 PM Ended: Jul 23, 2024 6:59 PM

Review all test suite changes for PR #5100 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Kelsey-Ethyca Kelsey-Ethyca Kelsey-Ethyca approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@andres-torres-marroquin @Kelsey-Ethyca