Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2409 By default, don't show data categories that are disabled #5102

Conversation

lucanovera
Copy link
Contributor

Description Of Changes

In the taxonomy picker by default, don't show data categories that are disabled.

Code Changes

  • Added showDisabled prop to TaxonomySelectDropdown defaulting to false
  • Added filtering in the FE for categories that aren't active

Steps to Confirm

Need to have D&D setup and some classification results.

  • Log in to admin ui
  • Go to Settings > Taxonomy, and disable a data category
  • Go to data discovery
  • Use the taxonomy picker and check that the data category that is disabled isn't shown as an option

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 18, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 18, 2024 6:54pm

Copy link

cypress bot commented Jul 18, 2024

Passing run #9001 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 4fb932a into 2c99458...
Project: fides Commit: 32fbbc4d80 ℹ️
Status: Passed Duration: 00:35 💡
Started: Jul 18, 2024 7:00 PM Ended: Jul 18, 2024 7:00 PM

Review all test suite changes for PR #5102 ↗︎

@lucanovera lucanovera requested a review from NevilleS July 18, 2024 18:43
@lucanovera lucanovera merged commit a24f3f6 into main Jul 18, 2024
13 checks passed
@lucanovera lucanovera deleted the PROD-2409-Taxonomy-picker-shouldn-t-show-inactive-data-categories branch July 18, 2024 19:52
lucanovera added a commit that referenced this pull request Jul 18, 2024
…5102)

Co-authored-by: Lucano Vera <lucanovera@ethyca.com>
Copy link

cypress bot commented Jul 18, 2024

Passing run #9006 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

PROD-2409 By default, don't show data categories that are disabled (#5102)
Project: fides Commit: a24f3f6ed4
Status: Passed Duration: 00:35 💡
Started: Jul 18, 2024 8:03 PM Ended: Jul 18, 2024 8:03 PM

Review all test suite changes for PR #5102 ↗︎

@cypress cypress bot mentioned this pull request Jul 18, 2024
34 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants