"activate" default locale during fallback of GVL language error #5106
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Passing run #9018 ↗︎
Details:
Review all test suite changes for PR #5106 ↗︎ |
||||||||||||||||||||
SteveDMurphy
approved these changes
Jul 19, 2024
SteveDMurphy
approved these changes
Jul 19, 2024
There was a problem hiding this comment.
Looks good @gilluminate ! Can maybe just pop something in the changelog for this too!
|
Thanks @SteveDMurphy! We're planning to get this in as a late add to the current release. Since this addresses an issue created by that release I opted to leave it off the changelog. |
Passing run #9029 ↗︎
Details:
Review all test suite changes for PR #5106 ↗︎ |
||||||||||||||||||||
gilluminate
added a commit
that referenced
this pull request
Jul 19, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes PROD-2413
Description Of Changes
When GVL languages are not available, the UI should fall back to the default language (English) even when the locale is set to something else.
Code Changes
DEFAULT_LOCALEi18n.activate(DEFAULT_LOCALE)during fallback to fix fallback bug.Steps to Confirm
https://privacy-plus-rc.fides-staging.ethyca.com/api/v1/privacy-experience/gvl/translations*)Pre-Merge Checklist