Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unused index #5122

Merged
merged 1 commit into from
Jul 22, 2024
Merged

Remove unused index #5122

merged 1 commit into from
Jul 22, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Jul 22, 2024

Description Of Changes

Removing index=True for the property_id field of ConsentRequest to prevent the index from being added during Alembic autogenerate

Steps to Confirm

  • Start fides nox -s dev
  • Shell into fides nox -s shell
  • Navigate to src/fides/api/alembic/ and run alembic revision --autogenerate -m "testing"
  • Verify the generated Alembic file doesn't have any migrations

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met

Copy link

vercel bot commented Jul 22, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Jul 22, 2024 9:10pm

Copy link

cypress bot commented Jul 22, 2024

Passing run #9077 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 21798a1 into 8312146...
Project: fides Commit: 9b8667a314 ℹ️
Status: Passed Duration: 00:35 💡
Started: Jul 22, 2024 9:21 PM Ended: Jul 22, 2024 9:21 PM

Review all test suite changes for PR #5122 ↗︎

Copy link

codecov bot commented Jul 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 86.54%. Comparing base (8312146) to head (21798a1).
Report is 1 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5122   +/-   ##
=======================================
  Coverage   86.54%   86.54%           
=======================================
  Files         357      357           
  Lines       22345    22345           
  Branches     2954     2954           
=======================================
  Hits        19339    19339           
  Misses       2482     2482           
  Partials      524      524           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@galvana galvana merged commit dd69a98 into main Jul 22, 2024
45 checks passed
@galvana galvana deleted the Remove-unused-index branch July 22, 2024 22:08
Copy link

cypress bot commented Jul 22, 2024

Passing run #9079 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Remove unused index (#5122)
Project: fides Commit: dd69a98721
Status: Passed Duration: 00:38 💡
Started: Jul 22, 2024 10:20 PM Ended: Jul 22, 2024 10:20 PM

Review all test suite changes for PR #5122 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants