Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Require Plus for D&D integrations notice to be shown on system form #5129

Merged
merged 1 commit into from
Jul 26, 2024

Conversation

jpople
Copy link
Contributor

@jpople jpople commented Jul 25, 2024

Description Of Changes

Prevents link to the new integration management view from being shown in system form tabs if user doesn't have Plus enabled.

Steps to Confirm

With "Detection & Discovery" beta flag enabled, visit a system information form's "Integrations" tab. With Plus enabled, should see notice about detection & discovery integrations being at Integration Management; without Plus, should see description of integrations without link.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Jul 25, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Jul 25, 2024 9:15pm

@jpople jpople changed the title Require Plus for new integrations view Require Plus for D&D integrations notice to be shown on system form Jul 25, 2024
@galvana galvana self-requested a review July 25, 2024 21:23
Copy link

cypress bot commented Jul 25, 2024

Passing run #9146 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Merge 661442d into 14211e3...
Project: fides Commit: d9706da117 ℹ️
Status: Passed Duration: 00:35 💡
Started: Jul 25, 2024 9:26 PM Ended: Jul 25, 2024 9:27 PM

Review all test suite changes for PR #5129 ↗︎

Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected 👍

with plus
image

without plus
image

@jpople jpople merged commit cd35f63 into main Jul 26, 2024
13 checks passed
@jpople jpople deleted the jpople/new-integration-notice-fix branch July 26, 2024 00:06
Copy link

cypress bot commented Jul 26, 2024

Passing run #9148 ↗︎

0 4 0 0 Flakiness 0
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.

Details:

Require Plus for D&D integrations notice to be shown on system form (#5129)
Project: fides Commit: cd35f63265
Status: Passed Duration: 00:36 💡
Started: Jul 26, 2024 12:17 AM Ended: Jul 26, 2024 12:18 AM

Review all test suite changes for PR #5129 ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants