PROD-2426 Adds new config options to support notice-only banner + modal #5136
Conversation
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
eastandwestwind
force-pushed
the
PROD-2426
branch
from
768e5e5 to
b218980
Compare
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #5136 +/- ##
==========================================
- Coverage 86.56% 86.54% -0.02%
==========================================
Files 357 357
Lines 22354 22330 -24
Branches 2957 2955 -2
==========================================
- Hits 19351 19326 -25
Misses 2480 2480
- Partials 523 524 +1 ☔ View full report in Codecov by Sentry. |
eastandwestwind
force-pushed
the
PROD-2426
branch
from
1c219d2 to
def5009
Compare
eastandwestwind
changed the title
| @declared_attr | ||
| def layer1_button_options(cls) -> Column: | ||
| return Column( | ||
| EnumColumn(Layer1ButtonOption), | ||
| nullable=True, | ||
| index=False, | ||
| ) |
There was a problem hiding this comment.
What's the reason for making this a declared_attr?
There was a problem hiding this comment.
This is similar to how we declare ComponentType(Enum). Basically using this instead of formalizing it in the DB allows for more flexibility with future enum changes where we won't need a whole migration.
|
Test summaryRun details
This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud |
Closes https://ethyca.atlassian.net/browse/PROD-2426
Description Of Changes
Adds 2 new config options to support notice-only banner + modal
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdmaindowngrade()migration is correct and works