Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Text fixes on monitor configuration UI #5142

Merged
merged 3 commits into from
Jul 31, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ The types of changes are:
- Changed text on system integrations tab to direct to new integration management [#5097](https://github.com/ethyca/fides/pull/5097)
- Updates to consent experience styling [#5085](https://github.com/ethyca/fides/pull/5085)
- Moves some endpoints for property-specific messaging from OSS -> plus [#5069](https://github.com/ethyca/fides/pull/5069)
- Text changes in monitor config table and form [#5142](https://github.com/ethyca/fides/pull/5142)

### Developer Experience
- Add `.syncignore` to reduce file sync size with new volumes [#5104](https://github.com/ethyca/fides/pull/5104)
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -7,7 +7,7 @@ import useCumulativeGetDatabases from "~/features/integrations/configure-monitor
import { MonitorConfig } from "~/types/api";

const TOOLTIP_COPY =
"Selecting a project will monitor all current and future datasets found.";
"Selecting a project will monitor all current and future datasets within that project.";
const ConfigureMonitorDatabasesForm = ({
monitor,
isEditing,
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -157,7 +157,7 @@ const MonitorConfigTab = ({
isDisplayAll
/>
),
header: (props) => <DefaultHeaderCell value="Location" {...props} />,
header: (props) => <DefaultHeaderCell value="Scope" {...props} />,
}),
columnHelper.accessor((row) => row.execution_frequency, {
id: "frequency",
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -84,7 +84,7 @@ const MonitorDatabasePicker = ({
columnHelper.accessor((row) => row.id, {
id: "id",
cell: (props) => <DefaultCell value={props.getValue()} />,
header: (props) => <DefaultHeaderCell value="Projects" {...props} />,
header: (props) => <DefaultHeaderCell value="Scope" {...props} />,
}),
],
[handleToggleSelection, handleToggleAll, allSelected, someSelected]
Expand Down
Loading