Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

PROD-2626 Privacy-Request-screen-crashes-when-daysLeft-null #5213

Merged

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Aug 19, 2024

Description Of Changes

Fix privacy request screen crashes when a PrivacyRequestResponse daysLeft property is null.

Screen Shot 2024-08-19 at 16 27 47

Code Changes

  • Change RequestDaysLeftCell to return null if daysLeft is null

Steps to Confirm

  • list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Issue Requirements are Met
  • Update CHANGELOG.md

Copy link

vercel bot commented Aug 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Aug 19, 2024 7:43pm

Copy link

cypress bot commented Aug 19, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit fc2d118fea ℹ️
Started Aug 19, 2024 7:57 PM
Ended Aug 19, 2024 7:57 PM
Duration 00:38 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

@lucanovera lucanovera requested a review from jpople August 20, 2024 16:02
Copy link
Contributor

@jpople jpople left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's so annoying. Well spotted!

@lucanovera lucanovera merged commit 3b9029f into main Aug 20, 2024
13 checks passed
@lucanovera lucanovera deleted the PROD-2626-Privacy-Request-screen-crashes-when-daysLeft-null branch August 20, 2024 16:25
Copy link

cypress bot commented Aug 20, 2024



Test summary

4 0 0 0


Run details

Project fides
Status Passed
Commit 3b9029f
Started Aug 20, 2024 4:37 PM
Ended Aug 20, 2024 4:38 PM
Duration 00:37 💡
OS Linux Ubuntu -
Browser Electron 106

View run in Cypress Cloud ➡️


This comment has been generated by cypress-bot as a result of this project's GitHub integration settings. You can manage this integration in this project's settings in the Cypress Cloud

Roger-Ethyca pushed a commit that referenced this pull request Aug 20, 2024
Co-authored-by: Lucano Vera <lucanovera@ethyca.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants