Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix "download" button icon placement #5409

Merged
merged 3 commits into from
Oct 23, 2024
Merged

Fix "download" button icon placement #5409

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
92bd16e
fix 'download' button styling on datamap report and privacy request t…
jpople Oct 23, 2024
2935583
remove unnecessary size change
jpople Oct 23, 2024
bd28c1b
update changelog
jpople Oct 23, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -28,6 +28,7 @@ The types of changes are:
- Fixed a bug where D&D tables were rendering stale data [#5372](https://github.com/ethyca/fides/pull/5372)
- Fixed issue where multiple login redirects could end up losing login return path [#5389](https://github.com/ethyca/fides/pull/5389)
- Fixed issue where Dataset with nested fields was unable to edit Categories [#5383](https://github.com/ethyca/fides/pull/5383)
- Fixed a visual bug where the "download" icon was off-center in some buttons [#5409](https://github.com/ethyca/fides/pull/5409)

### Developer Experience
- Fix warning messages from slowapi and docker [#5385](https://github.com/ethyca/fides/pull/5385)
Expand Down
2 changes: 1 addition & 1 deletion clients/admin-ui/src/features/datamap/reporting/DatamapReportTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -476,7 +476,7 @@ export const DatamapReportTable = () => {
data-testid="export-btn"
size="small"
onClick={onExportReportOpen}
icon={<DownloadLightIcon />}
icon={<DownloadLightIcon ml="1.5px" />}
/>
<Menu placement="bottom-end">
<MenuButton
Expand Down
2 changes: 1 addition & 1 deletion clients/admin-ui/src/features/privacy-requests/RequestTable.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -147,7 +147,7 @@ export const RequestTable = ({ ...props }: BoxProps): JSX.Element => {
aria-label="Export report"
data-testid="export-btn"
size="small"
icon={<DownloadLightIcon />}
icon={<DownloadLightIcon ml="1.5px" />}
onClick={handleExport}
/>
</HStack>
Expand Down
Loading