Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix Integration Tests #5421

Merged
merged 19 commits into from
Oct 30, 2024
Merged

Fix Integration Tests #5421

merged 19 commits into from
Oct 30, 2024

Conversation

Linker44
Copy link
Contributor

@Linker44 Linker44 commented Oct 25, 2024 •
edited
Loading

Closes #LA-58

Description Of Changes

This pr intends to fix all tests that we want to leave on fides.

Code Changes

  • Removed skips from tests
  • Modify tests so that they can run without the missing integrations

Steps to Confirm

  • Check that the CI pipline succeded.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@Linker44 Linker44 self-assigned this Oct 25, 2024
@vercel Vercel
Copy link

vercel bot commented Oct 25, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 30, 2024 1:28pm

@Linker44 Linker44 marked this pull request as draft October 25, 2024 14:00
@Linker44 Linker44 force-pushed the fix_integration_tests_and_move_to_plus branch from 783bc76 to 15c8baf Compare October 25, 2024 14:00
@Linker44 Linker44 changed the title Fix test connection config endpoints tests Fix Integration Tests Oct 25, 2024
@cypress Cypress
Copy link

cypress bot commented Oct 25, 2024 •
edited
Loading

fides    Run #10686

Run Properties:  status check passed Passed #10686  •  git commit be96a605fd ℹ️: Merge 19cda7013a8f1f43682d1306074a81b22add648c into de822cb80d9705046fcc4d327cab...
Project fides
Branch Review refs/pull/5421/merge
Run status status check passed Passed #10686
Run duration 00m 37s
Commit git commit be96a605fd ℹ️: Merge 19cda7013a8f1f43682d1306074a81b22add648c into de822cb80d9705046fcc4d327cab...
Committer Facundo Lopez Janza
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@codecov Codecov
Copy link

codecov bot commented Oct 25, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 85.47%. Comparing base (6db9bbc) to head (19cda70).
Report is 5 commits behind head on main.

Additional details and impacted files 
@@            Coverage Diff             @@
##             main    #5421      +/-   ##
==========================================
+ Coverage   83.87%   85.47%   +1.59%     
==========================================
  Files         384      384              
  Lines       24116    24116              
  Branches     2624     2624              
==========================================
+ Hits        20228    20612     +384     
+ Misses       3306     2950     -356     
+ Partials      582      554      -28

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@Linker44 Linker44 force-pushed the fix_integration_tests_and_move_to_plus branch from a4346b9 to dce1396 Compare October 29, 2024 19:46
@Linker44 Linker44 marked this pull request as ready for review October 29, 2024 19:46
@Linker44 Linker44 requested a review from a team as a code owner October 29, 2024 19:46
Vagoasdf
Vagoasdf approved these changes Oct 30, 2024
View reviewed changes
Copy link
Contributor

@Vagoasdf Vagoasdf left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks pretty good all around, thanks for the work!

Just some minor comments about a comment, but nothing that should block it from being merged

tests/ops/api/v1/endpoints/test_connection_template_endpoints.py Show resolved Hide resolved
@Linker44 Linker44 requested a review from galvana October 30, 2024 18:11
@galvana galvana added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Oct 30, 2024
@galvana galvana merged commit 08537cb into main Oct 30, 2024
39 checks passed
@galvana galvana deleted the fix_integration_tests_and_move_to_plus branch October 30, 2024 21:06
@cypress Cypress
Copy link

cypress bot commented Oct 30, 2024

fides    Run #10697

Run Properties:  status check passed Passed #10697  •  git commit 08537cbe69: Fix Integration Tests (#5421)
Project fides
Branch Review main
Run status status check passed Passed #10697
Run duration 00m 37s
Commit git commit 08537cbe69: Fix Integration Tests (#5421)
Committer Facundo Lopez Janza
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Vagoasdf Vagoasdf Vagoasdf approved these changes

@galvana galvana galvana approved these changes

Assignees

@Linker44 Linker44

Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Linker44 @galvana @Vagoasdf