Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HJ-115 - Integrate 1Password with GitHub Actions for Credential Management #5427

Merged
merged 2 commits into from
Oct 30, 2024

Conversation

andres-torres-marroquin
Copy link
Contributor

Closes #HJ-115

Description Of Changes

Integrate 1Password with GitHub Actions for Credential Management

Code Changes

  • list your code changes here

Steps to Confirm

  • Look at the tests passing in this PR.

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation:
    • documentation complete, PR opened in fidesdocs
    • documentation issue created in fidesdocs
    • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md
  • For API changes, the Postman collection has been updated
  • If there are any database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!

@andres-torres-marroquin andres-torres-marroquin added the run unsafe ci checks Runs fides-related CI checks that require sensitive credentials label Oct 28, 2024
Copy link

vercel bot commented Oct 28, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Oct 28, 2024 5:33pm

Copy link

cypress bot commented Oct 28, 2024

fides    Run #10642

Run Properties:  status check passed Passed #10642  •  git commit f808a2916b ℹ️: Merge 5194ef8ccd97a2f3718874ae24687c1dd2c794fb into 79ba117468367ef5faaabbd7a99a...
Project fides
Branch Review refs/pull/5427/merge
Run status status check passed Passed #10642
Run duration 00m 38s
Commit git commit f808a2916b ℹ️: Merge 5194ef8ccd97a2f3718874ae24687c1dd2c794fb into 79ba117468367ef5faaabbd7a99a...
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Oct 28, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 83.89%. Comparing base (79ba117) to head (5194ef8).
Report is 6 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5427   +/-   ##
=======================================
  Coverage   83.89%   83.89%           
=======================================
  Files         384      384           
  Lines       24112    24112           
  Branches     2624     2624           
=======================================
  Hits        20228    20228           
  Misses       3302     3302           
  Partials      582      582           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@andres-torres-marroquin andres-torres-marroquin merged commit eac2542 into main Oct 30, 2024
35 of 42 checks passed
@andres-torres-marroquin andres-torres-marroquin deleted the andres/HJ-115 branch October 30, 2024 14:42
Copy link

cypress bot commented Oct 30, 2024

fides    Run #10688

Run Properties:  status check passed Passed #10688  •  git commit eac2542b07: HJ-115 - Integrate 1Password with GitHub Actions for Credential Management (#542...
Project fides
Branch Review main
Run status status check passed Passed #10688
Run duration 00m 40s
Commit git commit eac2542b07: HJ-115 - Integrate 1Password with GitHub Actions for Credential Management (#542...
Committer Andres Torres
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
run unsafe ci checks Runs fides-related CI checks that require sensitive credentials
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants