HJ-116 - Fix BigQuery partitioning queries to properly support multiple identity clauses

[andres-torres-marroquin]

Fix BigQuery partitioning support bug - WHERE queries are not properly generated

Closes #HJ-116

Description Of Changes

Update BigQuery to use parenthesis on the WHERE clause for SELECT queries.

Code Changes

• Update BigQueryQueryConfig.get_formatted_query_string to surround the WHERE clause contents in parenthesis always.

Steps to Confirm

• Run the test suite.

Pre-Merge Checklist

• All CI Pipelines Succeeded
• Documentation:
  • documentation complete, PR opened in fidesdocs
  • documentation issue created in fidesdocs
  • if there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
• Issue Requirements are Met
• Relevant Follow-Up Issues Created
• Update CHANGELOG.md
• For API changes, the Postman collection has been updated
• If there are any database migrations:
  • Ensure that your downrev is up to date with the latest revision on main
  • Ensure that your downgrade() migration is correct and works
    • If a downgrade migration is not possible for this change, please call this out in the PR description!

[vercel]

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	⬜️ Ignored (Inspect)	Visit Preview		Oct 31, 2024 7:17pm

[cypress]

fides    Run #10721

Run Properties:   Passed #10721  •  8a1be3eeab ℹ️: Merge 59f86bed0706f1885c8f70ed7dd0adf19191d45a into 008cf6818d94915fbdf3a41138ff...

Project	fides
Branch Review	refs/pull/5432/merge
Run status	Passed #10721
Run duration	00m 37s
Commit	8a1be3eeab ℹ️: Merge 59f86bed0706f1885c8f70ed7dd0adf19191d45a into 008cf6818d94915fbdf3a41138ff...
Committer	Andres Torres
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	4
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

[codecov]

Codecov Report

Attention: Patch coverage is 40.00000% with 3 lines in your changes missing coverage. Please review.

Project coverage is 85.47%. Comparing base (4dd5bff) to head (c50b73d).
Report is 1 commits behind head on main.

Files with missing lines	Patch %	Lines
src/fides/api/service/connectors/query_config.py	40.00%	3 Missing ⚠️

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #5432   +/-   ##
=======================================
  Coverage   85.47%   85.47%           
=======================================
  Files         384      384           
  Lines       24118    24118           
  Branches     2624     2624           
=======================================
  Hits        20614    20614           
  Misses       2950     2950           
  Partials      554      554           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[NevilleS]

@andres-torres-marroquin I don't see any tests here that also exercise the partitioning clauses. I'd like to be extra confident that we've tested how those get merged into the rest

[andres-torres-marroquin]

@andres-torres-marroquin I don't see any tests here that also exercise the partitioning clauses. I'd like to be extra confident that we've tested how those get merged into the rest

@NevilleS Actually this test uses the partitioning clause, do you want me to add one that uses more than one identifying field? or a more explicit check?

[NevilleS]

@andres-torres-marroquin I don't see any tests here that also exercise the partitioning clauses. I'd like to be extra confident that we've tested how those get merged into the rest

@NevilleS Actually this test uses the partitioning clause, do you want me to add one that uses more than one identifying field? or a more explicit check?

Yes, I'd like to ensure there is an explicit test that shows the query we generate when there is a partitioning clause and multiple identities.

[NevilleS]

This looks good. The test feels awkward but that's non-blocking- maybe you can simplify that assertion...?

[cypress]

fides    Run #10722

Run Properties:   Passed #10722  •  b0f976a11b: HJ-116 - Fix BigQuery `partitioning` queries to properly support multiple identi...

Project	fides
Branch Review	main
Run status	Passed #10722
Run duration	00m 36s
Commit	b0f976a11b: HJ-116 - Fix BigQuery `partitioning` queries to properly support multiple identi...
Committer	Andres Torres
View all properties for this run ↗︎

---

Test results
Failures	0
Flaky	0
Pending	0
Skipped	0
Passing	4
⚠️ You've recorded test results over your free plan limit. Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎