-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix missing default icon #5440
Merged
Merged
Fix missing default icon #5440
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
improving log error with exception stacktrace
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
Linker44
approved these changes
Oct 31, 2024
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nice!
fides Run #10708
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5440/merge
|
Run status |
Passed #10708
|
Run duration | 00m 37s |
Commit |
bdf9bb30a0 ℹ️: Merge 0d43a57d1ff9ea81e2208b404f33303a357237af into 4e832b93c50d9a8eac8dd4c2e156...
|
Committer | Bruno Gutierrez Rios |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
fides Run #10716
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #10716
|
Run duration | 00m 37s |
Commit |
4dd5bff493: Fix missing default icon (#5440)
|
Committer | Bruno Gutierrez Rios |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Adding back missing default logo.
This was causing a breaking change when an integration was updated without an .svg logo, which prevented the loading of all the SaaS integrations
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md