Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix missing default icon #5440

Merged
merged 2 commits into from
Oct 31, 2024
Merged

Fix missing default icon #5440

merged 2 commits into from
Oct 31, 2024

Conversation

Vagoasdf
Copy link
Contributor

Description Of Changes

Adding back missing default logo.
This was causing a breaking change when an integration was updated without an .svg logo, which prevented the loading of all the SaaS integrations

Code Changes

  • adding default.svg file
  • Improving exception logging on setup

Steps to Confirm

  • Copy one of the current SaaS configs and datasets.
  • Rename them.
  • Rename the type in the config
  • Check that the integration appears when creating a new system
  • Check that the default logo is correct

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Update CHANGELOG.md

@Vagoasdf Vagoasdf requested a review from a team as a code owner October 31, 2024 16:04
Copy link

vercel bot commented Oct 31, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Oct 31, 2024 4:04pm

Copy link
Contributor

@Linker44 Linker44 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice!

Copy link

cypress bot commented Oct 31, 2024

fides    Run #10708

Run Properties:  status check passed Passed #10708  •  git commit bdf9bb30a0 ℹ️: Merge 0d43a57d1ff9ea81e2208b404f33303a357237af into 4e832b93c50d9a8eac8dd4c2e156...
Project fides
Branch Review refs/pull/5440/merge
Run status status check passed Passed #10708
Run duration 00m 37s
Commit git commit bdf9bb30a0 ℹ️: Merge 0d43a57d1ff9ea81e2208b404f33303a357237af into 4e832b93c50d9a8eac8dd4c2e156...
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@Vagoasdf Vagoasdf merged commit 4dd5bff into main Oct 31, 2024
37 checks passed
@Vagoasdf Vagoasdf deleted the fix_missing_default_icon branch October 31, 2024 18:18
Copy link

cypress bot commented Oct 31, 2024

fides    Run #10716

Run Properties:  status check passed Passed #10716  •  git commit 4dd5bff493: Fix missing default icon (#5440)
Project fides
Branch Review main
Run status status check passed Passed #10716
Run duration 00m 37s
Commit git commit 4dd5bff493: Fix missing default icon (#5440)
Committer Bruno Gutierrez Rios
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants