Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HJ-166: Use BlueConic Profile API correctly. #5487

Merged
merged 1 commit into from
Nov 12, 2024

Conversation

tvandort
Copy link
Contributor

@tvandort tvandort commented Nov 12, 2024

Closes HJ-166

Description Of Changes

Uses the BlueConic API correctly.

Code Changes

  • Get profile before using it.

Steps to Confirm

NA

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Nov 12, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Nov 12, 2024 3:49pm

Copy link

cypress bot commented Nov 12, 2024

fides    Run #10944

Run Properties:  status check passed Passed #10944  •  git commit 0c28eaf68d ℹ️: Merge d6bb3cd9538934e0544efef206958b47895f0655 into f6025520c1fda77b223034d9505e...
Project fides
Branch Review refs/pull/5487/merge
Run status status check passed Passed #10944
Run duration 00m 37s
Commit git commit 0c28eaf68d ℹ️: Merge d6bb3cd9538934e0544efef206958b47895f0655 into f6025520c1fda77b223034d9505e...
Committer Tom Van Dort
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@tvandort tvandort merged commit 2583b1c into main Nov 12, 2024
13 checks passed
@tvandort tvandort deleted the HJ-166-use-blueconic-profiles-correctly branch November 12, 2024 16:10
Copy link

cypress bot commented Nov 12, 2024

fides    Run #10947

Run Properties:  status check passed Passed #10947  •  git commit 2583b1cf7e: HJ-166: Use BlueConic Profile API correctly. (#5487)
Project fides
Branch Review main
Run status status check passed Passed #10947
Run duration 00m 41s
Commit git commit 2583b1cf7e: HJ-166: Use BlueConic Profile API correctly. (#5487)
Committer Tom Van Dort
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants