Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix misalignment of "powered by" brand link #5496

Merged
merged 2 commits into from
Nov 14, 2024
Merged

Fix misalignment of "powered by" brand link #5496

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
37f2a43
add min-height to secondary actions when brand is present
jpople Nov 14, 2024
5cd0e02
update changelog
jpople Nov 14, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,6 +42,7 @@ The types of changes are:

### Fixed
- Use BlueConic Profile API correctly. [#5487](https://github.com/ethyca/fides/pull/5487)
- Fixed a bug where branding link was sometimes misaligned [#5496](https://github.com/ethyca/fides/pull/5496)

## [2.49.0](https://github.com/ethyca/fidesplus/compare/2.48.2...2.49.0)

Expand Down
2 changes: 1 addition & 1 deletion clients/fides-js/src/components/ConsentButtons.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -111,7 +111,7 @@ export const ConsentButtons = ({
: "fides-banner-button-group fides-banner-secondary-actions"
}${includeLanguageSelector ? " fides-button-group-i18n" : ""}${
includePrivacyPolicyLink ? " fides-button-group-privacy-policy" : ""
}`}
}${includeBrandLink ? " fides-button-group-brand" : ""}`}
>
{includeLanguageSelector && (
<LanguageSelector
Expand Down
13 changes: 9 additions & 4 deletions clients/fides-js/src/components/fides.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,6 +79,10 @@
--fides-overlay-banner-offset: 48px;
--fides-banner-font-size-title: var(--16px);
--fides-overlay-language-loading-indicator-speed: 5s;
--fides-overlay-modal-secondary-button-group-height: calc(
var(--fides-overlay-font-size-body) +
(var(--fides-overlay-link-v-padding) * 2)
);
}

@keyframes spin {
Expand Down Expand Up @@ -481,6 +485,10 @@ div#fides-consent-content .fides-modal-description {
justify-content: center;
}

.fides-modal-container .fides-button-group-brand {
min-height: var(--fides-overlay-modal-secondary-button-group-height);
}

.fides-modal-secondary-actions .fides-brand {
position: absolute;
right: var(--fides-overlay-padding);
Expand Down Expand Up @@ -1022,10 +1030,7 @@ div#fides-overlay-wrapper .fides-toggle .fides-toggle-display {
}

.fides-modal-container .fides-button-group-i18n {
min-height: calc(
var(--fides-overlay-font-size-body) +
(var(--fides-overlay-link-v-padding) * 2)
);
min-height: var(--fides-overlay-modal-secondary-button-group-height);
}

div.fides-i18n-pseudo-button {
Expand Down
Loading