Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove extra delete icon from domains page buttons #5513

Merged
merged 2 commits into from
Nov 19, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
1 change: 1 addition & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -26,6 +26,7 @@ The types of changes are:

### Fixed
- Fixed deletion of ConnectionConfigs that have related MonitorConfigs [#5478](https://github.com/ethyca/fides/pull/5478)
- Fixed extra delete icon on Domains page [#5513](https://github.com/ethyca/fides/pull/5513)

### Changed
- Allow hiding systems via a `hidden` parameter and add two flags on the `/system` api endpoint; `show_hidden` and `dnd_relevant`, to display only systems with integrations [#5484](https://github.com/ethyca/fides/pull/5484)
Expand Down
6 changes: 2 additions & 4 deletions clients/admin-ui/src/pages/settings/domains.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -212,14 +212,12 @@ const CORSConfigurationPage: NextPage = () => {

<Button
aria-label="delete-domain"
className="z-[2] ml-8"
className="z-[2] ml-4"
icon={<DeleteIcon />}
onClick={() => {
arrayHelpers.remove(index);
}}
>
<DeleteIcon />
</Button>
/>
</Flex>
),
)}
Expand Down
Loading