LA-141 Apply privacy policy override even when locale doesn't match #5515
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5515/merge
|
| Run status |
|
| Run duration | 00m 39s |
| Commit |
|
| Committer | Lucano Vera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
eastandwestwind
approved these changes
Nov 20, 2024
| expect(mockI18n.load).toHaveBeenCalledWith("es", { | ||
| ...mockI18nCatalogLoad[1], | ||
| "exp.privacy_policy_url": | ||
| experienceTranslationOverrides.privacy_policy_url, |
added 2 commits
November 20, 2024 10:58
…Apply-fides_privacy_policy_url-CMP-override-at-all-times-regardless-of-language
lucanovera
deleted the
LA-141-Mediavine-Apply-fides_privacy_policy_url-CMP-override-at-all-times-regardless-of-language
branch
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 38s |
| Commit |
|
| Committer | Lucano Vera |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description Of Changes
Apply privacy policy override even when locale doesn't match
Code Changes
Steps to Confirm
You can use fides-js-demo.html to test
<script> window.fides_overrides = { fides_override_language: "es", fides_privacy_policy_url: "https://ethyca.com", }; </script>Pre-Merge Checklist
CHANGELOG.mdupdated