Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Removing Segment request overrides #5521

Merged
merged 1 commit into from
Nov 20, 2024
Merged

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Nov 20, 2024

Description Of Changes

Moving Segment request overrides to Fidesplus

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@galvana galvana requested a review from a team as a code owner November 20, 2024 18:33
Copy link

vercel bot commented Nov 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Nov 20, 2024 6:33pm

@galvana galvana requested a review from RobertKeyser November 20, 2024 18:33
@galvana galvana merged commit a01c21c into main Nov 20, 2024
18 checks passed
@galvana galvana deleted the remove-segment-request-override branch November 20, 2024 18:47
Copy link

cypress bot commented Nov 20, 2024

fides    Run #11120

Run Properties:  status check passed Passed #11120  •  git commit fcdf0eb5d7 ℹ️: Merge b1ab8a4c0e558974066398cc8f66e5c2eb8d9d04 into 34802667ec8f69d8277664d4d1b3...
Project fides
Branch Review refs/pull/5521/merge
Run status status check passed Passed #11120
Run duration 00m 40s
Commit git commit fcdf0eb5d7 ℹ️: Merge b1ab8a4c0e558974066398cc8f66e5c2eb8d9d04 into 34802667ec8f69d8277664d4d1b3...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Nov 20, 2024

fides    Run #11121

Run Properties:  status check passed Passed #11121  •  git commit a01c21c42c: Removing Segment request overrides (#5521)
Project fides
Branch Review main
Run status status check passed Passed #11121
Run duration 00m 38s
Commit git commit a01c21c42c: Removing Segment request overrides (#5521)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants