Mobile Native POC support work #5541

gilluminate · 2024-11-25T22:06:50Z

Closes HJ-259

Description Of Changes

Includes prep-work needed to be done in Fides before the native POC can work as intended

New option override fides_consent_override which will automatically set the user’s consent preference.
New script consent method to distinguish between manual and automated consent.
Update Cookie House sample app to be mobile friendly
Other minor house-keeping with Cookie House to keep it up to date with React and Next versions.

Steps to Confirm

Visit Cookie House on a mobile sized screen and ensure it looks decent
Visit the Cookie House in a location where a banner would normally appear with a query param that tells it to reject all notices: http://localhost:3000/?geolocation=EEA&fides_consent_override=reject
Ensure that a) the banner never showed and b) the cookie was sent in such a way that it mimics as if the user had clicked the "Reject All" button on the banner.
Clear the cookies and visit the Cookie House again with a query param that tells it to accept all notices: http://localhost:3000/?geolocation=EEA&fides_consent_override=accept
Ensure that a) the banner never showed and b) the cookie was sent in such a way that it mimics as if the user had clicked the "Accept All" button on the banner.

BEFORE:

AFTER:

Pre-Merge Checklist

vercel · 2024-11-25T22:06:55Z

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment

Name	Status	Preview	Comments	Updated (UTC)
fides-plus-nightly	⬜️ Ignored (Inspect)	Visit Preview		Dec 3, 2024 6:18pm

cypress · 2024-11-25T22:22:24Z

fides Run #11249

Run Properties: Passed #11249 • f9208df1c9 ℹ️: Merge 3ac980db916b7dbfde342ef8d10ca307419e8f97 into a601fbeeaece3ce7fe6c48a577ac...

Project	`fides`
Branch Review	`refs/pull/5541/merge`
Run status	`Passed #11249`
Run duration	`00m 49s`
Commit	`f9208df1c9 ℹ️: Merge 3ac980db916b7dbfde342ef8d10ca307419e8f97 into a601fbeeaece3ce7fe6c48a577ac...`
Committer	`Jason Gill`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`4`
View all changes introduced in this branch ↗︎

gilluminate · 2024-11-27T19:37:34Z

clients/fides-js/src/components/Overlay.tsx

-            onSave: () => {
-              setBannerIsOpen(false);
-            },


onSave was just superfluous and confusing so I removed it in favor of onClose everywhere.

clients/fides-js/src/components/notices/NoticeOverlay.tsx

clients/fides-js/src/components/tcf/TcfOverlay.tsx

gilluminate · 2024-11-27T19:51:09Z

clients/fides-js/src/fides-ext-gpp.ts

+      fidesDebugger(
+        `GPP: CMP status and configuration for ${geolocation?.location}`,
+        {
+          cmpStatus: cmpApi.getCmpStatus(),
+          cmpDisplayStatus: cmpApi.getCmpDisplayStatus(),
+          signalStatus: cmpApi.getSignalStatus(),
+          supportedAPIs: cmpApi.getSupportedAPIs(),
+          applicableSections: cmpApi.getApplicableSections(),
+          gppString: cmpApi.getGppString(),
+          parsedSections: cmpApi.getObject(),
+        },
+      );


a minor wish-list item I'm sneaking in to this PR :)

gilluminate · 2024-11-27T19:53:13Z

clients/privacy-center/cypress/fixtures/consent/experience_tcf_minimal.json

@@ -89,6 +89,221 @@
      "geolocation": {
        "location": "eea",
        "country": "eea"
+      },
+      "gvl": {


automated preference saving was throwing an error because this was missing from the minimal experience mocks

gilluminate · 2024-11-27T19:54:13Z

clients/sample-app/src/pages/_app.tsx

-  <Component {...pageProps} />
-);
+const App = ({ Component, pageProps }: AppProps) => {
+  const AnyComponent = Component as any;


weird solution to a weird Typescript problem with NextJS types.

gilluminate · 2024-12-02T15:45:20Z

clients/fides-js/src/components/notices/NoticeOverlay.tsx

@@ -229,6 +229,47 @@ const NoticeOverlay: FunctionComponent<OverlayProps> = ({
    ],
  );

+  const handleAcceptAll = useCallback(


bumped these up to parent to take advantage of them at this level for the automated preference

eastandwestwind

Looking good so far @gilluminate ! Nice work implementing for not only notice-based but also TCF version as well.

eastandwestwind · 2024-12-03T15:04:43Z

clients/fides-js/src/components/tcf/TcfOverlay.tsx

                  renderFirstButton={() => (
                    <Button
                      buttonType={ButtonType.SECONDARY}
                      label={i18n.t("exp.save_button_label")}
-                      onClick={() => onSave(ConsentMethod.SAVE, draftIds!)}
+                      onClick={() => onSave(ConsentMethod.SAVE, draftIds)}


what did the ! actually do before?

Its purpose is to tell the Typescript validator to ignore the fact that it might be null/undefined whereas (in this case) the onSave method expects it to have a value. Usually reserved for something where the developer is 100% sure that value will be set by the time it hits this chunk of code, I find it's usually abused and prone to unexpected bugs so I prefer cleaning it up wherever possible. In this case I set the value explicitly on line 174, giving the useState a default.

clients/fides-js/src/fides-tcf.ts

clients/fides-js/src/fides.ts

clients/privacy-center/app/server-utils/loadEnvironmentVariables.ts

cypress · 2024-12-03T21:52:40Z

fides Run #11250

Run Properties: Passed #11250 • 8723d8468f: Mobile Native POC support work (#5541)

Project	`fides`
Branch Review	`main`
Run status	`Passed #11250`
Run duration	`00m 55s`
Commit	`8723d8468f: Mobile Native POC support work (#5541)`
Committer	`Jason Gill`
View all properties for this run ↗︎

Test results
Failures	`0`
Flaky	`0`
Pending	`0`
Skipped	`0`
Passing	`4`
View all changes introduced in this branch ↗︎

gilluminate added 2 commits November 25, 2024 13:24

upgrade react & next

e3541d9

mobile friendly cookie house

ca2be22

gilluminate force-pushed the gill/HJ-259/poc-prep-work branch 4 times, most recently from 426c328 to 3af1ba8 Compare November 26, 2024 17:56

gilluminate added 2 commits November 26, 2024 16:38

add come convenient logging for GPP

cca94e2

add fides_reject_all override option

c126f4e

gilluminate force-pushed the gill/HJ-259/poc-prep-work branch 2 times, most recently from 8d650fb to 7e5a316 Compare November 27, 2024 00:07

gilluminate added 2 commits November 27, 2024 11:24

add fides_accept_all override option

05bd0a5

add tests for accept and reject

860925f

gilluminate force-pushed the gill/HJ-259/poc-prep-work branch from 7e5a316 to 860925f Compare November 27, 2024 18:24

rename and consolidate the option

4933ba5

gilluminate commented Nov 27, 2024

View reviewed changes

clients/fides-js/src/components/notices/NoticeOverlay.tsx Outdated Show resolved Hide resolved

gilluminate commented Nov 27, 2024

View reviewed changes

clients/fides-js/src/components/tcf/TcfOverlay.tsx Outdated Show resolved Hide resolved

gilluminate commented Nov 27, 2024

View reviewed changes

add new consent methods for known preference settings

18a0509

vercel bot deployed to Preview November 27, 2024 19:58 View deployment

gilluminate requested review from NevilleS and eastandwestwind November 27, 2024 19:59

gilluminate commented Dec 2, 2024

View reviewed changes

eastandwestwind requested changes Dec 3, 2024

View reviewed changes

gilluminate added 2 commits December 3, 2024 09:18

rename option and methods as per group discussion

2bdcf7f

fix delete cookie script for Safari iOS browsers

b077d02

gilluminate added 2 commits December 3, 2024 09:21

Update Overlay.tsx

463fed0

update comment

705666c

gilluminate marked this pull request as ready for review December 3, 2024 16:53

gilluminate requested a review from eastandwestwind December 3, 2024 16:53

Merge branch 'main' into gill/HJ-259/poc-prep-work

b7e3529

vercel bot deployed to Preview December 3, 2024 17:58 View deployment

gilluminate added 3 commits December 3, 2024 11:01

Update CHANGELOG.md

60dee8c

reusable isConsentOverride util

8753dbf

Update NoticeOverlay.tsx

3ac980d

eastandwestwind approved these changes Dec 3, 2024

View reviewed changes

gilluminate merged commit 8723d84 into main Dec 3, 2024
43 checks passed

gilluminate deleted the gill/HJ-259/poc-prep-work branch December 3, 2024 21:35

andres-torres-marroquin pushed a commit that referenced this pull request Dec 11, 2024

Mobile Native POC support work (#5541)

6bcfb60

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Mobile Native POC support work #5541

Mobile Native POC support work #5541

gilluminate commented Nov 25, 2024 •

edited

Loading

vercel bot commented Nov 25, 2024 •

edited

Loading

cypress bot commented Nov 25, 2024 •

edited

Loading

gilluminate Nov 27, 2024

gilluminate Nov 27, 2024

gilluminate Nov 27, 2024

gilluminate Nov 27, 2024

gilluminate Dec 2, 2024

eastandwestwind left a comment

eastandwestwind Dec 3, 2024

gilluminate Dec 3, 2024 •

edited

Loading

cypress bot commented Dec 3, 2024

Mobile Native POC support work #5541

Mobile Native POC support work #5541

Conversation

gilluminate commented Nov 25, 2024 • edited Loading

Description Of Changes

Steps to Confirm

Pre-Merge Checklist

vercel bot commented Nov 25, 2024 • edited Loading

cypress bot commented Nov 25, 2024 • edited Loading

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

eastandwestwind left a comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

gilluminate Dec 3, 2024 • edited Loading

Choose a reason for hiding this comment

cypress bot commented Dec 3, 2024

gilluminate commented Nov 25, 2024 •

edited

Loading

vercel bot commented Nov 25, 2024 •

edited

Loading

cypress bot commented Nov 25, 2024 •

edited

Loading

gilluminate Dec 3, 2024 •

edited

Loading