Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Escape datetime and ObjectId values in test privacy results #5567

Merged
merged 2 commits into from
Dec 6, 2024

Conversation

galvana
Copy link
Contributor

@galvana galvana commented Dec 6, 2024

Closes LA-197

Description Of Changes

Fixes and issue where ObjectId values from MongoDB weren't being handled correctly by the get_test_privacy_request_results endpoint

Code Changes

  • Escaping raw access results before returning them in the API response

Steps to Confirm

  1. Start Fides nox -s dev -- mongodb
  2. Create this dataset mongo_example_test_dataset.txt
  3. Create a system named "MongoDB" and configure the MongoDB integration. Attach the dataset from step 2
[mongodb_example]
server="mongodb_example"
user="mongo_user"
password="mongo_pass"
db="mongo_test"
port=27017
  1. Navigate to http://localhost:3000/systems/configure/mongodb/test-datasets
  2. Enter the following as the Test inputs
{
  "email": "customer-2@example.com",
  "postgres_example_test_dataset:customer:id": 1
}
  1. Hit run and verify the request is successful

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 6, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 6, 2024 4:07pm

Copy link

cypress bot commented Dec 6, 2024

fides    Run #11321

Run Properties:  status check passed Passed #11321  •  git commit 1c6be11f91 ℹ️: Merge ffe64d392b6d921882ae4bd76c6355db6fc2b4d6 into ca8e8470f38218fd95d448e1cf64...
Project fides
Branch Review refs/pull/5567/merge
Run status status check passed Passed #11321
Run duration 00m 48s
Commit git commit 1c6be11f91 ℹ️: Merge ffe64d392b6d921882ae4bd76c6355db6fc2b4d6 into ca8e8470f38218fd95d448e1cf64...
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

@galvana galvana merged commit 3f0c296 into main Dec 6, 2024
37 checks passed
@galvana galvana deleted the fix-test-privacy-results branch December 6, 2024 17:31
Copy link

cypress bot commented Dec 6, 2024

fides    Run #11327

Run Properties:  status check passed Passed #11327  •  git commit 3f0c29639d: Escape datetime and ObjectId values in test privacy results (#5567)
Project fides
Branch Review main
Run status status check passed Passed #11327
Run duration 00m 49s
Commit git commit 3f0c29639d: Escape datetime and ObjectId values in test privacy results (#5567)
Committer Adrian Galvan
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants