LA 194 refreshing oauth credentials #5569
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
refs/pull/5569/merge
|
| Run status |
|
| Run duration | 00m 48s |
| Commit |
|
| Committer | Bruno Gutierrez Rios |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
Failures
|
0
|
Flaky
|
0
|
Pending
|
0
|
Skipped
|
0
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
Vagoasdf
force-pushed
the
LA-194-Refreshing-Oauth-credentials
branch
from
5c2550f to
e2b1791
Compare
This reverts commit 84ce5c0.
The test that we care most about is test_oauth2_authentication_successful_refresh, since it test a proper refresh. Its working correctly Also removed some logging that carried over our research
Carry over from previous issue regarding client_credentials wich was patched last friday Dec 6
Vagoasdf
force-pushed
the
LA-194-Refreshing-Oauth-credentials
branch
from
e97ad47 to
9bd6c24
Compare
galvana
reviewed
Dec 9, 2024
src/fides/api/service/authentication/authentication_strategy_oauth2_client_credentials.py
Outdated
Show resolved
Hide resolved
galvana
approved these changes
Dec 9, 2024
…auth2_client_credentials.py Co-authored-by: Adrian Galvan <adrian@ethyca.com>
fides
|
||||||||||||||||||||||||||||||
| Project |
fides
|
| Branch Review |
main
|
| Run status |
|
| Run duration | 00m 55s |
| Commit |
|
| Committer | Bruno Gutierrez Rios |
| View all properties for this run ↗︎ | |
| Test results | |
|---|---|
|
Failures
|
0
|
|
Flaky
|
0
|
|
Pending
|
0
|
|
Skipped
|
0
|
|
Passing
|
4
|
Upgrade your plan to view test results. | |
| View all changes introduced in this branch ↗︎ | |
eastandwestwind
pushed a commit
that referenced
this pull request
Dec 10, 2024
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
andres-torres-marroquin
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
eastandwestwind
pushed a commit
that referenced
this pull request
Dec 11, 2024
Co-authored-by: Adrian Galvan <adrian@ethyca.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes LA#194
Description Of Changes
We were seeing trouble with OAuth Client Credentials strategies, as the token is not being refreshed properly, as the base class was expecting a refresh request to exist. For that, we are adding an override function on the Client Credentials strategy that can properly refresh the token
Code Changes
Adding a override function on OAuth2ClientCredentialsAuthenticationStrategy for refreshing the access token, using the base token request instead of the refresh request, since the Client Credentials OAuth connection does not uses a separate refresh request call.
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.mdupdated