Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

LA-56 Only trigger dataset save if values have changed #5612

Merged
merged 4 commits into from
Dec 17, 2024
Merged

LA-56 Only trigger dataset save if values have changed #5612

merged 4 commits into from
Dec 17, 2024

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Dec 17, 2024 •
edited
Loading

Code Changes

  • Added option to patchConnectionDatasetConfig to show/hide success alert (default: true)
  • Use option to hide alert when updating datasets from integration screen

Steps to Confirm

  1. Create a system, or open the system page for an existing system
  2. Go to the Integrations tab of the system page
  3. Add a database integration and save it
  4. Only one toast should show up saying "Integration successfully added!"
  5. Now hit save again
  6. Only one toast should show up saying "Integration successfully updated!"

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 17, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 17, 2024 5:14pm

@cypress Cypress
Copy link

cypress bot commented Dec 17, 2024 •
edited
Loading

fides    Run #11526

Run Properties:  status check passed Passed #11526  •  git commit 728bbebd03 ℹ️: Merge 2fc34866b7574f7c12505af73f4e74db238ddc7a into 36512e9897ac692467ef992c91d6...
Project fides
Branch Review refs/pull/5612/merge
Run status status check passed Passed #11526
Run duration 00m 46s
Commit git commit 728bbebd03 ℹ️: Merge 2fc34866b7574f7c12505af73f4e74db238ddc7a into 36512e9897ac692467ef992c91d6...
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@lucanovera lucanovera requested a review from galvana December 17, 2024 17:19
galvana
galvana approved these changes Dec 17, 2024
View reviewed changes
Copy link
Contributor

@galvana galvana left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Working as expected! Thanks for including the test instructions 👌

@lucanovera lucanovera merged commit 70272d1 into main Dec 17, 2024
13 checks passed
@lucanovera lucanovera deleted the LA-56-Remove-Dataset-updated-toast-when-creating-an-integration branch December 17, 2024 19:45
@cypress Cypress
Copy link

cypress bot commented Dec 17, 2024

fides    Run #11538

Run Properties:  status check passed Passed #11538  •  git commit 70272d1b1f: LA-56 Only trigger dataset save if values have changed (#5612)
Project fides
Branch Review main
Run status status check passed Passed #11538
Run duration 00m 58s
Commit git commit 70272d1b1f: LA-56 Only trigger dataset save if values have changed (#5612)
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@galvana galvana galvana approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucanovera @galvana