-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
LA-199: Enhanced functionality around handling taxonomy active / de-active nodes #5617
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 1 Skipped Deployment
|
eastandwestwind
force-pushed
the
LA-199
branch
from
December 18, 2024 14:49
9aec905
to
2ea6f36
Compare
fides Run #11594
Run Properties:
|
Project |
fides
|
Branch Review |
refs/pull/5617/merge
|
Run status |
Passed #11594
|
Run duration | 00m 59s |
Commit |
739671997c ℹ️: Merge 51857b59418af94e9ee66e810cd871f229199a5b into 8f8f6ea2ef75f2040c76404b98dd...
|
Committer | Catherine Smith |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
eastandwestwind
changed the title
LA-199
LA-199: Enhanced functionality around handling taxonomy active / de-active nodes
Dec 18, 2024
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5617 +/- ##
==========================================
- Coverage 87.16% 87.13% -0.04%
==========================================
Files 388 388
Lines 23940 23988 +48
Branches 2586 2594 +8
==========================================
+ Hits 20868 20902 +34
- Misses 2514 2525 +11
- Partials 558 561 +3 ☔ View full report in Codecov by Sentry. |
galvana
approved these changes
Dec 19, 2024
eastandwestwind
added a commit
that referenced
this pull request
Dec 19, 2024
…ctive nodes (#5617) Co-authored-by: Adrian Galvan <adrian@ethyca.com>
fides Run #11596
Run Properties:
|
Project |
fides
|
Branch Review |
main
|
Run status |
Passed #11596
|
Run duration | 00m 48s |
Commit |
f319894c92: LA-199: Enhanced functionality around handling taxonomy active / de-active nodes...
|
Committer | Catherine Smith |
View all properties for this run ↗︎ |
Test results | |
---|---|
Failures |
0
|
Flaky |
0
|
Pending |
0
|
Skipped |
0
|
Passing |
4
|
Upgrade your plan to view test results. | |
View all changes introduced in this branch ↗︎ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
❗ Contains 2 migrations ❗
Closes https://ethyca.atlassian.net/browse/LA-199
Description Of Changes
This PR does 2 things:
Adjusts functionality when the
active
field of taxonomy items are updated. If deactivating a node, we cascade deactivate children of a label. If activating a node, we ensure all its' parent nodes are activated.Adds a data migration such that if any currently de-active node has any number of
active
children, we enable that node so that it can be shown in the new Taxonomy UI. For this data migration, a downgrade is not possible as we do not track the changed taxonomy updates.Code Changes
active
fieldSteps to Confirm
Taxonomy
tab to view new Taxonomy UIPre-Merge Checklist
CHANGELOG.md
updatedmain
downgrade()
migration is correct and works