Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Taxonomy UI fixes #5625

Merged
merged 2 commits into from
Dec 19, 2024
Merged

Taxonomy UI fixes #5625

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
2de0f23
Fix bug where nodes disappear after creating new item
lucanovera Dec 19, 2024
21d473d
Increase small delay to center the screen as it sometimes fails
lucanovera Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions clients/admin-ui/src/features/taxonomy/components/TaxonomyInteractiveTree.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,9 +53,9 @@ const TaxonomyInteractiveTree = ({

// Reset the zoom level and center the view when the taxonomy type changes
useEffect(() => {
// Timeout is needed because fitView doesn't work if it's
// A small delay is needed because fitView doesn't work if it's
// called before the nodes are rendered
setTimeout(() => fitView(), 0);
setTimeout(() => fitView(), 150);
}, [fitView, taxonomyType]);

// Root node (the taxonomy type)
Expand Down
2 changes: 1 addition & 1 deletion clients/admin-ui/src/pages/taxonomy/index.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ const TaxonomyPage: NextPage = () => {
}
setLastCreatedItemKey(result.data.fides_key);
toast(successToastParams("New label successfully created"));
setTimeout(() => setDraftNewItem(null));
setDraftNewItem(null);
},
[createTrigger, draftNewItem, toast],
);
Expand Down
Loading