Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

LA-225 Datamap-report-page-breaks-if-there-are-no-results #5627

Merged

Conversation

lucanovera
Copy link
Contributor

Description Of Changes

Fix datamap report breaking when no it has no results

Code Changes

  • Check for datamap results length before accessing element

Steps to Confirm

  1. Delete all systems
  2. Go to Datamap Report page
  3. Check that it doesn't break when it doesn't have any results

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 19, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly 🔄 Building (Inspect) Visit Preview 💬 Add feedback Dec 19, 2024 9:38pm

@lucanovera lucanovera merged commit 185ad7e into main Dec 19, 2024
10 of 11 checks passed
@lucanovera lucanovera deleted the LA-225-Datamap-report-page-breaks-if-there-are-no-results branch December 19, 2024 21:39
Copy link

cypress bot commented Dec 19, 2024

fides    Run #11610

Run Properties:  status check passed Passed #11610  •  git commit 31aefdfdb6 ℹ️: Merge 92b16334285469115fd9ca44bcde06694dae422e into 365ffc53bbd4ebf43186259eb3df...
Project fides
Branch Review refs/pull/5627/merge
Run status status check passed Passed #11610
Run duration 00m 50s
Commit git commit 31aefdfdb6 ℹ️: Merge 92b16334285469115fd9ca44bcde06694dae422e into 365ffc53bbd4ebf43186259eb3df...
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

cypress bot commented Dec 19, 2024

fides    Run #11611

Run Properties:  status check passed Passed #11611  •  git commit 185ad7e59b: LA-225 Datamap-report-page-breaks-if-there-are-no-results (#5627)
Project fides
Branch Review main
Run status status check passed Passed #11611
Run duration 00m 50s
Commit git commit 185ad7e59b: LA-225 Datamap-report-page-breaks-if-there-are-no-results (#5627)
Committer Lucano Vera
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants