Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

HJ-319 Add cache-clearing methods to DBCache #5629

Merged
merged 2 commits into from
Dec 20, 2024
Merged

HJ-319 Add cache-clearing methods to DBCache #5629

merged 2 commits into from
Dec 20, 2024

Conversation

erosselli
Copy link
Contributor

@erosselli erosselli commented Dec 20, 2024

Relates to HJ-319

Description Of Changes

Adds some methods to DBCache that allow deleting a cached entry, deleting all cached entries for a given namespace, and deleting all entries.

Steps to Confirm

  1. list any manual steps for reviewers to confirm the changes

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

Copy link

vercel bot commented Dec 20, 2024

The latest updates on your projects. Learn more about Vercel for Git ↗︎

1 Skipped Deployment
Name Status Preview Comments Updated (UTC)
fides-plus-nightly ⬜️ Ignored (Inspect) Visit Preview Dec 20, 2024 1:21pm

@erosselli erosselli requested a review from adamsachs December 20, 2024 13:20
Copy link

cypress bot commented Dec 20, 2024

fides    Run #11617

Run Properties:  status check passed Passed #11617  •  git commit 50d3083f79 ℹ️: Merge 5137cdbfae2999de9a2619527e68943386b81082 into 185ad7e59b9cc26eef93c9703711...
Project fides
Branch Review refs/pull/5629/merge
Run status status check passed Passed #11617
Run duration 00m 48s
Commit git commit 50d3083f79 ℹ️: Merge 5137cdbfae2999de9a2619527e68943386b81082 into 185ad7e59b9cc26eef93c9703711...
Committer erosselli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Copy link

codecov bot commented Dec 20, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 87.14%. Comparing base (185ad7e) to head (5137cdb).
Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #5629   +/-   ##
=======================================
  Coverage   87.13%   87.14%           
=======================================
  Files         388      388           
  Lines       23988    24000   +12     
  Branches     2594     2594           
=======================================
+ Hits        20902    20914   +12     
  Misses       2525     2525           
  Partials      561      561           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good, nice additions to the model class

@erosselli erosselli merged commit f77633e into main Dec 20, 2024
39 checks passed
@erosselli erosselli deleted the HJ-319-v2 branch December 20, 2024 21:03
Copy link

cypress bot commented Dec 20, 2024

fides    Run #11627

Run Properties:  status check passed Passed #11627  •  git commit f77633e33a: HJ-319 Add cache-clearing methods to DBCache (#5629)
Project fides
Branch Review main
Run status status check passed Passed #11627
Run duration 01m 04s
Commit git commit f77633e33a: HJ-319 Add cache-clearing methods to DBCache (#5629)
Committer erosselli
View all properties for this run ↗︎

Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants