Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix creation of new root level labels #5630

Merged
merged 1 commit into from
Dec 20, 2024
Merged

Fix creation of new root level labels #5630

merged 1 commit into from
Dec 20, 2024

Conversation

lucanovera
Copy link
Contributor

@lucanovera lucanovera commented Dec 20, 2024 •
edited
Loading

Description Of Changes

Fix creation of root level new labels.

Code Changes

  • Use null as parent_key instead of root when creating root-level labels

Steps to Confirm

  1. Go to Taxonomy
  2. Try create a label from the top level (Data Categories, Data Uses, Data Subjects)

Pre-Merge Checklist

  • Issue requirements met
  • All CI pipelines succeeded
  • CHANGELOG.md updated
  • Followup issues:
    • Followup issues created (include link)
    • No followup issues
  • Database migrations:
    • Ensure that your downrev is up to date with the latest revision on main
    • Ensure that your downgrade() migration is correct and works
      • If a downgrade migration is not possible for this change, please call this out in the PR description!
    • No migrations
  • Documentation:
    • Documentation complete, PR opened in fidesdocs
    • Documentation issue created in fidesdocs
    • If there are any new client scopes created as part of the pull request, remember to update public-facing documentation that references our scope registry
    • No documentation updates required

@vercel Vercel
Copy link

vercel bot commented Dec 20, 2024 •
edited
Loading

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name Status Preview Comments Updated (UTC)
fides-plus-nightly ✅ Ready (Inspect) Visit Preview 💬 Add feedback Dec 20, 2024 5:35pm

@cypress Cypress
Copy link

cypress bot commented Dec 20, 2024

fides    Run #11620

Run Properties:  status check passed Passed #11620  •  git commit b7aca7da4a ℹ️: Merge ca739a03b0f6197914ea702c11b9eacb17dfc896 into 185ad7e59b9cc26eef93c9703711...
Project fides
Branch Review refs/pull/5630/merge
Run status status check passed Passed #11620
Run duration 00m 38s
Commit git commit b7aca7da4a ℹ️: Merge ca739a03b0f6197914ea702c11b9eacb17dfc896 into 185ad7e59b9cc26eef93c9703711...
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

@lucanovera lucanovera merged commit cf0e0f5 into main Dec 20, 2024
13 checks passed
@lucanovera lucanovera deleted the LA-227-creating-new-fields-at-data-use-and-data-cat-errors branch December 20, 2024 17:50
lucanovera added a commit that referenced this pull request Dec 20, 2024
@lucanovera
Fix creation of new root level labels (#5630)
86f60a7
@cypress Cypress
Copy link

cypress bot commented Dec 20, 2024

fides    Run #11621

Run Properties:  status check passed Passed #11621  •  git commit cf0e0f514e: Fix creation of new root level labels (#5630)
Project fides
Branch Review main
Run status status check passed Passed #11621
Run duration 00m 36s
Commit git commit cf0e0f514e: Fix creation of new root level labels (#5630)
Committer Lucano Vera
View all properties for this run ↗︎
Test results
Tests that failed  Failures 0
Tests that were flaky  Flaky 0
Tests that did not run due to a developer annotating a test with .skip  Pending 0
Tests that did not run due to a failure in a mocha hook  Skipped 0
Tests that passed  Passing 4
⚠️ You've recorded test results over your free plan limit.
Upgrade your plan to view test results.
View all changes introduced in this branch ↗︎

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@eastandwestwind eastandwestwind eastandwestwind approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucanovera @eastandwestwind