Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Collection-Level Masking Strategy Override and Erase After #17

Merged
merged 7 commits into from
Sep 24, 2024
Merged
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -16,6 +16,11 @@ The types of changes are:

## [Unreleased](https://github.com/ethyca/fideslang/compare/3.0.5...main)

### Changed

- Add collection-level masking strategy overrides and support specifying one collection to be erased after another [#17](https://github.com/ethyca/fideslang/pull/17)


## [3.0.5](https://github.com/ethyca/fideslang/compare/3.0.4...3.0.5)

### Added
Expand Down
14 changes: 14 additions & 0 deletions src/fideslang/models.py
Original file line number Diff line number Diff line change
Expand Up @@ -62,6 +62,18 @@
)


class MaskingStrategies(str, Enum):
"""Possible options for masking strategy overrides"""

DELETE = "delete"


class MaskingStrategyOverride(BaseModel):
"""Overrides policy-level masking strategies."""

strategy: MaskingStrategies


class FidesModel(BaseModel):
"""The base model for most top-level Fides objects."""

Expand Down Expand Up @@ -515,7 +527,9 @@ class CollectionMeta(BaseModel):
"""Collection-level specific annotations used for query traversal"""

after: Optional[List[FidesCollectionKey]] = None
erase_after: Optional[List[FidesCollectionKey]] = None
skip_processing: Optional[bool] = False
masking_strategy_override: Optional[MaskingStrategyOverride] = None


class DatasetCollection(FidesopsMetaBackwardsCompat):
Expand Down
19 changes: 18 additions & 1 deletion tests/fideslang/test_validation.py
Original file line number Diff line number Diff line change
Expand Up @@ -15,6 +15,8 @@
FidesDatasetReference,
FidesMeta,
FidesModel,
MaskingStrategies,
MaskingStrategyOverride,
Policy,
PolicyRule,
PrivacyDeclaration,
Expand Down Expand Up @@ -642,7 +644,7 @@ def test_specify_fides_meta_with_custom_request_field(self):
length=None,
return_all_elements=None,
read_only=None,
custom_request_field="site_id"
custom_request_field="site_id",
)

def test_specify_both_fidesops_meta_and_fides_meta(self):
Expand Down Expand Up @@ -789,6 +791,21 @@ def test_collection_key_has_too_many_components(self):
def test_valid_collection_key(self):
CollectionMeta(after=[FidesCollectionKey("test_dataset.test_collection")])

def test_delete_masking_strategy(self):
meta = CollectionMeta(masking_strategy_override={"strategy": "delete"})

assert meta.masking_strategy_override == MaskingStrategyOverride(
strategy=MaskingStrategies.DELETE
)

def test_erase_after(self):
meta = CollectionMeta(
erase_after=[FidesCollectionKey("test_dataset.test_collection")]
)

assert meta.erase_after == [FidesCollectionKey("test_dataset.test_collection")]



class TestAnyUrlString:
def test_valid_url(self):
Expand Down
Loading