Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Initial support for DatasetCollection partitioning specifications #21

Merged
merged 6 commits into from
Oct 2, 2024

Conversation

adamsachs
Copy link

@adamsachs adamsachs commented Sep 24, 2024

Description Of Changes

Initial partitioning specification (fides_meta.partitioning, on DatasetCollections) that's deliberately kept as an untyped Dict to allow open-ended experimentation in implementing applications.

Once we define a more robust and proper partitioning specification DSL, we can more strongly type this field accordingly.

Code Changes

  • add a partitioning untyped Optional[Dict] field to the CollectionMeta

Steps to Confirm

Pre-Merge Checklist

  • All CI Pipelines Succeeded
  • Documentation Updated
  • Issue Requirements are Met
  • Relevant Follow-Up Issues Created
  • Update CHANGELOG.md

@adamsachs adamsachs changed the title Asachs/prod 2734 fideslang Initial support for DatasetCollection partitioning specifications Sep 24, 2024
@adamsachs adamsachs marked this pull request as ready for review October 2, 2024 20:19
@adamsachs adamsachs self-assigned this Oct 2, 2024
@adamsachs adamsachs requested a review from pattisdr October 2, 2024 20:19
@adamsachs adamsachs merged commit 2f2d230 into main Oct 2, 2024
37 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants