HJ-20 save data categories nested fields #22
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
erosselli
reviewed
Oct 29, 2024
erosselli
reviewed
Oct 29, 2024
| ) | ||
|
|
||
| assert field | ||
| assert field.data_categories == ["user"] | ||
| assert field.fields[0].data_categories == ["user"] |
There was a problem hiding this comment.
real test here, a nested field can in fact have a category
| ), | ||
| fields=[DatasetField(name="nested_field")], | ||
| ) | ||
| assert_error_message_includes( |
There was a problem hiding this comment.
If we want users to add data categories to the "non-terminal" nested fields (middle fields, or top level) then this validation needs to be removed and the reverse of this test is now the case
| @@ -7,8 +7,8 @@ | |||
| from .data_uses import DEFAULT_DATA_USES | |||
| from .organizations import DEFAULT_ORGANIZATIONS | |||
|
|
|||
| sort_data_types = ( | |||
| lambda x: x.parent_key if hasattr(x, "parent_key") and x.parent_key else x.fides_key | |||
| sort_data_types = lambda x: ( | |||
erosselli
approved these changes
Nov 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Part of HJ-20
Description Of Changes
remove stipulation that sub fields can't have data categories
Code Changes
Steps to Confirm
Pre-Merge Checklist
CHANGELOG.md