Enable validation of events representing local servers #68
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
When submitting events to the `/events` endpoint that represent API requests made by a server running locally (Ex. a host of `0.0.0.0`), the endpoint validation fails due to a bug in the third-party validation library. These are legitimate events (or if they are illegitimate events, it is not due to this host value), so they should pass validation. The validator now simply replaces the `0.0.0.0` host with `localhost`. This does not affect event accuracy, because the endpoint URL is ultimately truncated such that it only includes the URL path.
eastandwestwind
approved these changes
Jun 20, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #67
When submitting events to the
/eventsendpoint that represent API requests made by a server running locally (Ex. a host of0.0.0.0), the endpoint validation fails due to a bug in the third-party validation library.These are legitimate events (or if they are illegitimate events, it is not due to this host value), so they should pass validation. The validator now simply replaces the
0.0.0.0host withlocalhost. This does not affect event accuracy, because the endpoint URL is ultimately truncated such that it only includes the URL path.