Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Increase the request rate limit to 100/min #74

Merged
merged 3 commits into from
Jul 14, 2022
Merged

Conversation

PSalant726
Copy link
Contributor

Closes #73

  • The request rate limit is now configurable via the FIDESLOG__SERVER_REQUEST_RATE_LIMIT ENV variable or:
    # fideslog.toml
    
    [server]
    request_rate_limit = "100/minute"
    • Defaults to 100 requests per minute
    • Affects all endpoints
  • The following headers are now included in 429 responses:
    • Retry-After: The datetime after which to retry the request
    • X-RateLimit-Limit: The number of allowed requests in the current period
    • X-RateLimit-Remaining: The number of remaining requests in the current period
    • X-RateLimit-Reset: The number of seconds left in the current period
  • Response schemas are now explicitly documented

@PSalant726 PSalant726 added documentation Improvements or additions to documentation enhancement New feature or request labels Jul 13, 2022
@PSalant726 PSalant726 requested a review from adamsachs July 13, 2022 23:50
@PSalant726 PSalant726 self-assigned this Jul 13, 2022
Copy link

@adamsachs adamsachs left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nice! thanks for bumping this so quick, and i like that you made it configurable - we can keep turning the knob higher without code changes if it looks like we've still got room to go with the new default.

everything looks by my eyes.

@PSalant726 PSalant726 merged commit 1532e63 into main Jul 14, 2022
@PSalant726 PSalant726 deleted the bump-rate-limit-5x branch July 14, 2022 16:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
documentation Improvements or additions to documentation enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Increase the rate limit to 100 requests/min
2 participants