Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow None as the value of local_host #79

Merged
merged 1 commit into from
Aug 4, 2022
Merged

Allow None as the value of local_host #79

merged 1 commit into from
Aug 4, 2022

Conversation

PSalant726
Copy link
Contributor

Closes #75

API Changes

  • Allow AnalyticsEvent.local_host to be None, but only when endpoint is also None
  • Validate the above

SDK Changes

  • Alow the AnalyticsEvent constructor to accept None as the value of the local_host parameter
  • Validate that local_host is only None if the endpoint parameter is also None

@PSalant726
Allow None as the value of local_host
0e19742 
But only for events without an `endpoint` value.
@PSalant726 PSalant726 added the enhancement New feature or request label Aug 4, 2022
@PSalant726 PSalant726 requested a review from pattisdr August 4, 2022 18:29
@PSalant726 PSalant726 self-assigned this Aug 4, 2022
pattisdr
pattisdr approved these changes Aug 4, 2022
View reviewed changes
Copy link

@pattisdr pattisdr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for jumping on this Phil!

fideslog/api/models/analytics_event.py Show resolved Hide resolved
@PSalant726 PSalant726 merged commit 9a43d2a into main Aug 4, 2022
@PSalant726 PSalant726 deleted the allow-no-localhost branch August 4, 2022 19:02
@pattisdr pattisdr mentioned this pull request Aug 22, 2022
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pattisdr pattisdr pattisdr approved these changes

Assignees

@PSalant726 PSalant726

Labels
enhancement New feature or request
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Allow Analytics Event localhost to be None
2 participants
@PSalant726 @pattisdr