Add user registration events #87
Conversation
There was a problem hiding this comment.
In addition to my below comments, it's important to keep the docs updated. Can you comb through https://github.com/ethyca/fideslog/blob/main/README.md and https://github.com/ethyca/fideslog/blob/main/fideslog/sdk/python/README.md, and make any necessary changes to those files as well?
The `FIDESLOG__DATABASE_ENCRYPTION_KEY` ENV variable should be set to a non-default value.
There was a problem hiding this comment.
This looks solid, thanks @TheAndrewJackson and @PSalant726. Just one or two minor docs nits.
Separately, I don't think there's an API here for us to use to fetch decrypted data from the system. Can we create a follow-up for that?
|
|
||
| assert value.find("@") == -1, "client_id must not be identifiable" | ||
| return value | ||
| _check_in_the_past: classmethod = validator( |
There was a problem hiding this comment.
Just to check here - these timestamps are generated server-side right? I feel like I saw them in the client code as well, and while it's likely to work fine most of the time eventually a bad system clock could be an issue...
There was a problem hiding this comment.
Correct - these timestamps are created during the database interactions that create/update the registrations records. The validation needs to exist on the off chance that a user tries to populate these fields manually.
| ECS_CLUSTER_NAME: ${{ secrets.ECS_CLUSTER_NAME }} | ||
| FIDESLOG__SECURITY__ACCESS_TOKEN: ${{secrets.FIDESLOG__SECURITY__ACCESS_TOKEN}} |
There was a problem hiding this comment.
This secret has been added to the repository and the engineering 1pw vault.
|
Thanks for the work here @PSalant726 + @TheAndrewJackson |
Change the wording slightly to allow CLI some flexibility
There was a problem hiding this comment.
None of the comments are blocking so I've logged them as follow-up issues.
Closes #82
Changes