Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Cleaner artifact generation #25

Open
wants to merge 4 commits into
base: main
Choose a base branch
from
Open

Conversation

etpinard
Copy link
Owner

inspired by https://github.com/sglyon/PlotlyBase.jl/blob/master/deps/generate_artifacts.jl so that we now use the following official methods exported from Pkg.Artifacts:

  • create_artifacts
  • archive_artifact (which creates a new tarball and should work across platforms, unlike tar)
  • bind_artifact! (which writes the Artifact.toml content)

Moreover, I think we'll be able to remove

- name: Set-up DastTextareaAutocomplete artifact directory
# This step is used to skip artifact download as the url/hash found
# in 'Artifacts.toml' might not be valid anymore after `npm run build`
run: |
julia -e 'using Pkg.Artifacts; \
using Tar, TOML; \
res_key = "dash_textarea_autocomplete_resources"; \
d = TOML.tryparsefile("Artifacts.toml"); \
hash = d[res_key]["git-tree-sha1"]; \
Tar.extract("deps/deps.tar", mkpath(artifact_path(Base.SHA1(hash))));'

that is, Pkg.add(url=\"$GITHUB_SERVER_URL/$GITHUB_REPOSITORY\", rev=\"$GITHUB_SHA\"); should just work now.


Oh well, we don't need to merge this PR and maybe we shouldn't for now.

@Felix-Gauthier I think we have spent enough time on dash-textarea-autocomplete in the last 10 days or so. Consider this PR documentation for future dash-textarea-autocomplete work.

@Felix-Gauthier
Copy link
Collaborator

This looks great, we're better of using this one julia script than postbuild.sh + tweaks to CI

We could do a patch release after the holidays to use it 🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants